V2 New features#462
Quality Gate failed
Failed conditions
C Security Rating on New Code (required ≥ A)
See analysis details on SonarQube Cloud
Catch issues before they fail your Quality Gate with our IDE extension
SonarQube for IDE
Annotations
Check warning on line 101 in src/BlazorApp/Components/Shared/SvgChartHelpers.cs
sonarqubecloud / SonarCloud Code Analysis
Define a constant instead of using this literal 'text-anchor' 4 times.
See more on https://sonarcloud.io/project/issues?id=devpro_keeptrack&issues=AZ9hPTORJgY_rLCycmI_&open=AZ9hPTORJgY_rLCycmI_&pullRequest=462
Check failure on line 11 in src/BlazorApp/wwwroot/theme.js
sonarqubecloud / SonarCloud Code Analysis
Unexpected var, use let or const instead.
See more on https://sonarcloud.io/project/issues?id=devpro_keeptrack&issues=AZ9hPTOtJgY_rLCycmJI&open=AZ9hPTOtJgY_rLCycmJI&pullRequest=462
Check warning on line 103 in test/WebApi.IntegrationTests/Resources/AlbumReferenceRepositoryTest.cs
sonarqubecloud / SonarCloud Code Analysis
Prefer using 'string.Equals(string, StringComparison)' to perform a case-insensitive comparison, but keep in mind that this might cause subtle changes in behavior, so make sure to conduct thorough testing after applying the suggestion, or if culturally sensitive comparison is not required, consider using 'StringComparison.OrdinalIgnoreCase'
See more on https://sonarcloud.io/project/issues?id=devpro_keeptrack&issues=AZ9hPTSRJgY_rLCycmJb&open=AZ9hPTSRJgY_rLCycmJb&pullRequest=462
Check warning on line 102 in src/BlazorApp/Components/Shared/SvgChartHelpers.cs
sonarqubecloud / SonarCloud Code Analysis
Define a constant instead of using this literal 'class' 4 times.
See more on https://sonarcloud.io/project/issues?id=devpro_keeptrack&issues=AZ9hPTORJgY_rLCycmJA&open=AZ9hPTORJgY_rLCycmJA&pullRequest=462
Check warning on line 59 in src/WebApi/ReferenceData/OpenLibraryClient.cs
sonarqubecloud / SonarCloud Code Analysis
Change this code to not construct the URL from user-controlled data.
See more on https://sonarcloud.io/project/issues?id=devpro_keeptrack&issues=AZ9hPTLCJgY_rLCycmIK&open=AZ9hPTLCJgY_rLCycmIK&pullRequest=462
Check warning on line 28 in src/WebApi/ReferenceData/ReferenceDataController.cs
sonarqubecloud / SonarCloud Code Analysis
Constructor has 11 parameters, which is greater than the 7 authorized.
See more on https://sonarcloud.io/project/issues?id=devpro_keeptrack&issues=AZ9hPTLjJgY_rLCycmIU&open=AZ9hPTLjJgY_rLCycmIU&pullRequest=462
Check warning on line 17 in src/WebApi/ReferenceData/ReferenceDataController.cs
sonarqubecloud / SonarCloud Code Analysis
This controller has multiple responsibilities and could be split into 2 smaller controllers.
See more on https://sonarcloud.io/project/issues?id=devpro_keeptrack&issues=AZ9hPTLjJgY_rLCycmIV&open=AZ9hPTLjJgY_rLCycmIV&pullRequest=462
Check failure on line 25 in src/WebApi/ReferenceData/ReferenceSyncService.cs
sonarqubecloud / SonarCloud Code Analysis
Refactor this method to reduce its Cognitive Complexity from 40 to the 15 allowed.
See more on https://sonarcloud.io/project/issues?id=devpro_keeptrack&issues=AZ9hPTK6JgY_rLCycmIJ&open=AZ9hPTK6JgY_rLCycmIJ&pullRequest=462
Check warning on line 41 in src/BlazorApp/Components/Shared/SvgChartHelpers.cs
sonarqubecloud / SonarCloud Code Analysis
Method has 8 parameters, which is greater than the 7 authorized.
See more on https://sonarcloud.io/project/issues?id=devpro_keeptrack&issues=AZ9hPTORJgY_rLCycmJB&open=AZ9hPTORJgY_rLCycmJB&pullRequest=462
Check warning on line 309 in src/BlazorApp/Components/Inventory/Pages/VideoGameDetail.razor
sonarqubecloud / SonarCloud Code Analysis
Use a format provider when parsing date and time.
See more on https://sonarcloud.io/project/issues?id=devpro_keeptrack&issues=AZ9hPTNbJgY_rLCycmIw&open=AZ9hPTNbJgY_rLCycmIw&pullRequest=462
Check warning on line 69 in src/BlazorApp/Components/Shared/SvgChartHelpers.cs
sonarqubecloud / SonarCloud Code Analysis
Define a constant instead of using this literal 'stroke-width' 4 times.
See more on https://sonarcloud.io/project/issues?id=devpro_keeptrack&issues=AZ9hPTORJgY_rLCycmI8&open=AZ9hPTORJgY_rLCycmI8&pullRequest=462
sonarqubecloud / SonarCloud Code Analysis
Limit the content length of HTTP requests.
See more on https://sonarcloud.io/project/issues?id=devpro_keeptrack&issues=AZ9hPTOlJgY_rLCycmJE&open=AZ9hPTOlJgY_rLCycmJE&pullRequest=462
Check warning on line 123 in src/WebApi/ReferenceData/OpenLibraryClient.cs
sonarqubecloud / SonarCloud Code Analysis
Pass a timeout to limit the execution time.
See more on https://sonarcloud.io/project/issues?id=devpro_keeptrack&issues=AZ9hPTLCJgY_rLCycmIM&open=AZ9hPTLCJgY_rLCycmIM&pullRequest=462
Check warning on line 16 in src/Domain/Services/HouseMetricsService.cs
sonarqubecloud / SonarCloud Code Analysis
Member 'ComputeMetrics' does not access instance data and can be marked as static
See more on https://sonarcloud.io/project/issues?id=devpro_keeptrack&issues=AZ9hPTNBJgY_rLCycmIj&open=AZ9hPTNBJgY_rLCycmIj&pullRequest=462
Check warning on line 61 in src/WebApi/Program.cs
sonarqubecloud / SonarCloud Code Analysis
Refactor your code not to use hardcoded absolute paths or URIs.
See more on https://sonarcloud.io/project/issues?id=devpro_keeptrack&issues=AZ9hPTMbJgY_rLCycmIb&open=AZ9hPTMbJgY_rLCycmIb&pullRequest=462
Check failure on line 12 in src/BlazorApp/wwwroot/theme.js
sonarqubecloud / SonarCloud Code Analysis
Unexpected var, use let or const instead.
See more on https://sonarcloud.io/project/issues?id=devpro_keeptrack&issues=AZ9hPTOtJgY_rLCycmJK&open=AZ9hPTOtJgY_rLCycmJK&pullRequest=462
Check warning on line 202 in src/BlazorApp/Components/Inventory/Pages/MovieDetail.razor
sonarqubecloud / SonarCloud Code Analysis
Extract this nested ternary operation into an independent statement.
See more on https://sonarcloud.io/project/issues?id=devpro_keeptrack&issues=AZ9hPTOCJgY_rLCycmI5&open=AZ9hPTOCJgY_rLCycmI5&pullRequest=462
Check failure on line 2 in src/BlazorApp/wwwroot/theme.js
sonarqubecloud / SonarCloud Code Analysis
Unexpected var, use let or const instead.
See more on https://sonarcloud.io/project/issues?id=devpro_keeptrack&issues=AZ9hPTOtJgY_rLCycmJF&open=AZ9hPTOtJgY_rLCycmJF&pullRequest=462
Check warning on line 18 in src/WebApi/Import/CarHistoryImportController.cs
sonarqubecloud / SonarCloud Code Analysis
Limit the content length of HTTP requests.
See more on https://sonarcloud.io/project/issues?id=devpro_keeptrack&issues=AZ9hPTLtJgY_rLCycmIW&open=AZ9hPTLtJgY_rLCycmIW&pullRequest=462
Check warning on line 21 in src/WebApi/Controllers/WishlistController.cs
sonarqubecloud / SonarCloud Code Analysis
Constructor has 8 parameters, which is greater than the 7 authorized.
See more on https://sonarcloud.io/project/issues?id=devpro_keeptrack&issues=AZ9hPTMGJgY_rLCycmIZ&open=AZ9hPTMGJgY_rLCycmIZ&pullRequest=462
Check failure on line 4 in src/BlazorApp/wwwroot/theme.js
sonarqubecloud / SonarCloud Code Analysis
Prefer `.dataset` over `setAttribute(…)`.
See more on https://sonarcloud.io/project/issues?id=devpro_keeptrack&issues=AZ9hPTOtJgY_rLCycmJH&open=AZ9hPTOtJgY_rLCycmJH&pullRequest=462
Check failure on line 3 in src/BlazorApp/wwwroot/theme.js
sonarqubecloud / SonarCloud Code Analysis
Unexpected var, use let or const instead.
See more on https://sonarcloud.io/project/issues?id=devpro_keeptrack&issues=AZ9hPTOtJgY_rLCycmJG&open=AZ9hPTOtJgY_rLCycmJG&pullRequest=462
Check warning on line 34 in src/WebApi/ReferenceData/ReferenceSyncBackgroundService.cs
sonarqubecloud / SonarCloud Code Analysis
Evaluation of this argument may be expensive and unnecessary if logging is disabled
See more on https://sonarcloud.io/project/issues?id=devpro_keeptrack&issues=AZ9hPTKqJgY_rLCycmIH&open=AZ9hPTKqJgY_rLCycmIH&pullRequest=462
Check warning on line 78 in src/WebApi/Program.cs
sonarqubecloud / SonarCloud Code Analysis
Refactor your code not to use hardcoded absolute paths or URIs.
See more on https://sonarcloud.io/project/issues?id=devpro_keeptrack&issues=AZ9hPTMbJgY_rLCycmId&open=AZ9hPTMbJgY_rLCycmId&pullRequest=462
Check warning on line 33 in test/WebApi.UnitTests/ReferenceData/OpenLibraryClientTest.cs
sonarqubecloud / SonarCloud Code Analysis
Change return type of method 'BuildClient' from 'Keeptrack.WebApi.ReferenceData.IBookReferenceClient' to 'Keeptrack.WebApi.ReferenceData.OpenLibraryClient' for improved performance
See more on https://sonarcloud.io/project/issues?id=devpro_keeptrack&issues=AZ9hPTScJgY_rLCycmJc&open=AZ9hPTScJgY_rLCycmJc&pullRequest=462