test: add integration tests#16
Open
radiovisual wants to merge 15 commits into
Open
Conversation
Author
|
Also, according to the README, there is a feature mentioned that you can override the entry file, but that feature seems to have been removed in this commit. I had this test written for the feature, but of course it was failing, since the feature is not supported: it('should override the entry file if a new one is supplied', async () => {
const inputFilePath = getFixtureFilePath('no-shebang.js');
const bundle = await getRollUpBundle(inputFilePath, {
entry: getFixtureFilePath('hello-world-cli.js')
});
const generatedCode = await getGeneratedContent(bundle, format);
expect(generatedCode.split('\n')[0]).toEqual(nodeShebang);
expect(generatedCode).toMatchSnapshot();
});I removed the mention of the unsupported feature via 0b0116b |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This plugin is missing tests, so I wrote some integration tests that test the plugin with rollup.
Changes
masterWorkflow status
Here is proof that the tests are running and passing on my branch:
and here is the status badge:
WDYT @developit ?