Support .cjs files imported with @rollup/plugin-commonjs#15
Open
aloisklink wants to merge 1 commit into
Open
Conversation
Add support for CommonJS files loaded with @rollup/plugin-commonjs.
If try to run rollup-plugin-preserve-shebang on a CommonJS file
(e.g. one that uses `const x = require("...");` syntax instead of
`import`),
[@rollup/plugin-commonjs](https://www.npmjs.com/package/@rollup/plugin-commonjs)
will append `?commonjs-entry` to the end of the id.
E.g. in `transform(code, modId)`, `modId = "...example.js"`
However, in `renderChunk()`,
`chunk.facadeModuleId = "...example.js?commonjs-entry"`.
In order to get the original module id, you need to remove `?commonjs-entry`.
|
I encountered exactly the same issue, would be helpful if this PR can be merged. |
|
I am not sure this is true anymore. I don't know what has changed since this was opened two year ago, but I just tested the scenario this PR attempts to fix (alongside my PR that adds integration tests #16) and I can't reproduce this. Is it still valid? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for CommonJS files loaded with
@rollup/plugin-commonjs.If try to run rollup-plugin-preserve-shebang on a CommonJS file
(e.g. one that uses
const x = require("...");syntax instead ofimport),@rollup/plugin-commonjs
will append
?commonjs-entryto the end of the id.This means that
renderChunk()will fail to add the shebang back to the file, since themoduleIdis different.E.g. in
transform(code, modId),modId = "...example.js"However, in
renderChunk(),chunk.facadeModuleId = "...example.js?commonjs-entry".In order to get the original module id, you need to remove
?commonjs-entry.