Repository navigation
feat(footer): add responsive navigation and accessible layout - #96
Heyykrishnna wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Yash121l
left a comment
There was a problem hiding this comment.
Approving. The footer is clearer, link targets are 44px, and the headings are correct (h2 inside labelled navs). All the old docs links survive through DOCS_NAV.
Nits, not blocking:
@/lib/constantsis imported twice (SITE_CONFIGandDOCS_NAV). Merge them into one import.aria-label="Find DevClub online"sits on a plaindiv. Screen readers ignore names on generic elements, so addrole="group"or make it aul.- The footer adds a second theme toggle next to the navbar one. Fine if intended.
- Several JSX lines run past 300 chars, which makes future diffs hard to review.
CI checks pass. The Vercel devclubcompo failure shows up on every PR and on main ("Account is blocked"), so it is not caused by this change.
|
@Heyykrishnna this is approved, but One-time setup (SSH signing): git config --global gpg.format ssh
git config --global user.signingkey ~/.ssh/id_ed25519.pub
git config --global commit.gpgsign trueAdd the same public key on GitHub under Settings → SSH and GPG keys → New SSH key with key type Signing Key. Also make sure the commit email ( Then on this branch: git rebase --exec 'git commit --amend --no-edit -S' origin/main
git push --force-with-leasePushing dismisses the current approval (that's a ruleset setting), so I'll re-approve once the commits show Verified. Auto-merge is enabled, so it merges after that. |
Summary
Rebuilt the footer as an elevated, responsive card with a clear heading, component CTA, grouped Explore/Learn/Connect navigation, social and contact links, legal links, and the existing theme control. Brand, newsletter, and control slots allow applications to extend the layout; newsletter behavior is supplied by consumers.
Related Issue
Closes #17
Type of Change
Component(s) Affected
src/components/layout/footer.tsxEngineering Quality Checklist
Validation
Checked desktop and 390px CSS mobile layouts for horizontal overflow, verified semantic navigation landmarks and 44px theme/social controls, and tested the theme toggle in both directions. Captured dark and light appearances.
The integrated
codex/stagingtree containing this PR passednpm run lint,npm run typecheck,npm run build,npm run check:lockfile, registry synchronization, andgit diff --check. Individual GitHub CI checks remain the merge gate.Visual Demonstration
Screenshots were captured from integrated staging.
Desktop · Mobile · Light theme