Skip to content

feat(footer): add responsive navigation and accessible layout - #96

Open
Heyykrishnna wants to merge 1 commit into
mainfrom
codex/feat-17-footer
Open

Heyykrishnna wants to merge 1 commit into
mainfrom
codex/feat-17-footer

Conversation

@Heyykrishnna

Copy link
Copy Markdown
Member

Summary

Rebuilt the footer as an elevated, responsive card with a clear heading, component CTA, grouped Explore/Learn/Connect navigation, social and contact links, legal links, and the existing theme control. Brand, newsletter, and control slots allow applications to extend the layout; newsletter behavior is supplied by consumers.

Related Issue

Closes #17

Type of Change

  • Enhancement / Accessibility

Component(s) Affected

  • src/components/layout/footer.tsx

Engineering Quality Checklist

  • Reused existing components, utilities, dependencies, and motion behavior.
  • No new dependencies or source comments.

Validation

Checked desktop and 390px CSS mobile layouts for horizontal overflow, verified semantic navigation landmarks and 44px theme/social controls, and tested the theme toggle in both directions. Captured dark and light appearances.

The integrated codex/staging tree containing this PR passed npm run lint, npm run typecheck, npm run build, npm run check:lockfile, registry synchronization, and git diff --check. Individual GitHub CI checks remain the merge gate.

Visual Demonstration

Screenshots were captured from integrated staging.

Desktop · Mobile · Light theme

@vercel

vercel Bot commented Oct 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
component-library Ready Ready Preview Oct 18, 2026 10:06am UTC

@Yash121l Yash121l left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. The footer is clearer, link targets are 44px, and the headings are correct (h2 inside labelled navs). All the old docs links survive through DOCS_NAV.

Nits, not blocking:

  • @/lib/constants is imported twice (SITE_CONFIG and DOCS_NAV). Merge them into one import.
  • aria-label="Find DevClub online" sits on a plain div. Screen readers ignore names on generic elements, so add role="group" or make it a ul.
  • The footer adds a second theme toggle next to the navbar one. Fine if intended.
  • Several JSX lines run past 300 chars, which makes future diffs hard to review.

CI checks pass. The Vercel devclubcompo failure shows up on every PR and on main ("Account is blocked"), so it is not caused by this change.

@Yash121l

Copy link
Copy Markdown
Contributor

@Heyykrishnna this is approved, but main requires verified commit signatures and the commits here are unsigned, so it can't merge yet. Can you re-sign and force-push?

One-time setup (SSH signing):

git config --global gpg.format ssh
git config --global user.signingkey ~/.ssh/id_ed25519.pub
git config --global commit.gpgsign true

Add the same public key on GitHub under Settings → SSH and GPG keys → New SSH key with key type Signing Key. Also make sure the commit email (khandelwalyatharth39@gmail.com) is a verified email on your GitHub account, otherwise the signature shows as unverified.

Then on this branch:

git rebase --exec 'git commit --amend --no-edit -S' origin/main
git push --force-with-lease

Pushing dismisses the current approval (that's a ruleset setting), so I'll re-approve once the commits show Verified. Auto-merge is enabled, so it merges after that.

@Yash121l
Yash121l enabled auto-merge (squash) October 18, 2026 10:43

This branch was successfully deployed

1 active deployment
Preview – component-library — 04d7af50 Deployed Oct 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/medium 100-299 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat]: Modernize and revamp site-wide Footer

2 participants