Skip to content

fix(studio): remove stacked calendar preview padding - #90

Merged
Yash121l merged 2 commits into
mainfrom
codex/fix-79-calendar-preview
Oct 19, 2026
Merged

Yash121l merged 2 commits into
mainfrom
codex/fix-79-calendar-preview

Conversation

@Heyykrishnna

@Heyykrishnna Heyykrishnna commented Oct 18, 2026 •

Copy link
Copy Markdown
Member

Summary

The Calendar Card demo no longer imposes a 512px minimum height or a second layer of desktop padding. The studio gives this demo its own small inset, allowing the existing responsive card to fit inside the phone screen.

Related Issue

Closes #79

Type of Change

  • Bug Fix

Component(s) Affected

  • src/components/showcase/component-studio.tsx

Engineering Quality Checklist

  • Reused existing components, utilities, dependencies, and motion behavior.
  • No new dependencies or source comments.

Validation

Verified the calendar fits the phone preview without a scrollbar: client and scroll height both measured 705px. Checked tablet layout.

The integrated codex/staging tree containing this PR passed npm run lint, npm run typecheck, npm run build, npm run check:lockfile, registry synchronization, and git diff --check. Individual GitHub CI checks remain the merge gate.

Integration Note

The toast-containment PR for #81 touches the adjacent Toaster line in this wrapper. Both fixes are resolved together on staging; update the remaining branch after the first PR merges.

Visual Demonstration

Screenshots were captured from integrated staging.

Mobile preview

Review follow-up

Re-signed the Calendar-only PR history. Toast changes continue separately in #100. A temporary base change caused the existing auto-merge to merge #92 into this issue branch; that branch update was reversed, restoring this PR to its Calendar-only head a53d9fe. Both active PRs target main. Whichever merges second requires rebasing onto main to preserve the adjacent wrapper and toaster changes; staging already validates their combined result.

@vercel

vercel Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
component-library Ready Ready Preview Oct 19, 2026 4:38am UTC

Yash121l
Yash121l previously approved these changes Oct 18, 2026

@Yash121l Yash121l left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Heads-up: this conflicts with #92 in component-studio.tsx (both edit the calendar-card wrapper/<Toaster /> lines). Whichever merges second needs a rebase. I checked all pairs among #86–#96, and this is the only conflict.

CI checks pass. The Vercel devclubcompo failure shows up on every PR and on main ("Account is blocked"), so it is not caused by this change.

@Yash121l

Copy link
Copy Markdown
Contributor

@Heyykrishnna this is approved, but main requires verified commit signatures and the commits here are unsigned, so it can't merge yet. Can you re-sign and force-push?

One-time setup (SSH signing):

git config --global gpg.format ssh
git config --global user.signingkey ~/.ssh/id_ed25519.pub
git config --global commit.gpgsign true

Add the same public key on GitHub under Settings → SSH and GPG keys → New SSH key with key type Signing Key. Also make sure the commit email (khandelwalyatharth39@gmail.com) is a verified email on your GitHub account, otherwise the signature shows as unverified.

Then on this branch:

git rebase --exec 'git commit --amend --no-edit -S' origin/main
git push --force-with-lease

Pushing dismisses the current approval (that's a ruleset setting), so I'll re-approve once the commits show Verified. Auto-merge is enabled, so it merges after that.

This PR and #92 conflict in component-studio.tsx. Whichever lands second needs the rebase anyway, and the rebase above covers it.

@Yash121l Yash121l left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-checked after the signed push. The code is identical to what I approved. LGTM.

@Yash121l
Yash121l merged commit d26ae87 into main Oct 19, 2026
14 checks passed
@Yash121l
Yash121l deleted the codex/fix-79-calendar-preview branch October 19, 2026 04:39
Yash121l pushed a commit that referenced this pull request Oct 19, 2026
## Summary

Keep fixed-position Toast and Calendar Card notifications inside the
mobile and tablet preview screens. The device wrapper supplies the
containing block and width limits; one typed toasterOffset value gives
both demos consistent clearances around the phone status bar and home
indicator.

## Related Issue

Closes #81

## Type of Change

- [x] Bug Fix

## Component(s) Affected

- `src/components/showcase/component-studio.tsx`

## Engineering Quality Checklist

- [x] Reused existing components, utilities, and dependencies.
- [x] No new dependencies or source comments.
- [x] All three PR commits are signed with the registered SSH signing
key.

## Integration

Rebased onto main at `0bf625a` after Calendar spacing PR #90 merged. The
conflict resolution preserves main’s `flex w-full items-center
justify-center p-2` Calendar wrapper and this PR’s shared toasterOffset
configuration. The PR contains only the Toast changes in one file.

## Validation

The rebased branch passed `npm run lint`, `npm run typecheck`, `npm run
check:lockfile`, `npm run build` (87 generated pages), and `git diff
--check`.

The resolved component-studio.tsx is identical to the previously
browser-tested staging version, which confirmed phone toast bounds
inside the device screen. GitHub CI and maintainer approval remain the
merge gates.

## Visual Demonstration

![Mobile
preview](https://raw.githubusercontent.com/devclub-nstru/component_library/6aca786/.github/assets/issue-resolution/81-mobile.png)

This branch was successfully deployed

2 active (1 outdated) deployments
Preview — 1497eb90 Deployed Oct 19, 2026 by vercel[bot]
Preview – component-library — 4bd1463b Deployed Oct 18, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/xs Under 10 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Calendar Card demo overflows the mobile preview and shows a scrollbar

2 participants