Repository navigation
fix(studio): remove stacked calendar preview padding - #90
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Yash121l
left a comment
There was a problem hiding this comment.
Looks good.
Heads-up: this conflicts with #92 in component-studio.tsx (both edit the calendar-card wrapper/<Toaster /> lines). Whichever merges second needs a rebase. I checked all pairs among #86–#96, and this is the only conflict.
CI checks pass. The Vercel devclubcompo failure shows up on every PR and on main ("Account is blocked"), so it is not caused by this change.
|
@Heyykrishnna this is approved, but One-time setup (SSH signing): git config --global gpg.format ssh
git config --global user.signingkey ~/.ssh/id_ed25519.pub
git config --global commit.gpgsign trueAdd the same public key on GitHub under Settings → SSH and GPG keys → New SSH key with key type Signing Key. Also make sure the commit email ( Then on this branch: git rebase --exec 'git commit --amend --no-edit -S' origin/main
git push --force-with-leasePushing dismisses the current approval (that's a ruleset setting), so I'll re-approve once the commits show Verified. Auto-merge is enabled, so it merges after that. This PR and #92 conflict in |
4bd1463 to
a53d9fe
Compare
5766883 to
a53d9fe
Compare
a53d9fe to
b02c5f7
Compare
Yash121l
left a comment
There was a problem hiding this comment.
Re-checked after the signed push. The code is identical to what I approved. LGTM.
## Summary Keep fixed-position Toast and Calendar Card notifications inside the mobile and tablet preview screens. The device wrapper supplies the containing block and width limits; one typed toasterOffset value gives both demos consistent clearances around the phone status bar and home indicator. ## Related Issue Closes #81 ## Type of Change - [x] Bug Fix ## Component(s) Affected - `src/components/showcase/component-studio.tsx` ## Engineering Quality Checklist - [x] Reused existing components, utilities, and dependencies. - [x] No new dependencies or source comments. - [x] All three PR commits are signed with the registered SSH signing key. ## Integration Rebased onto main at `0bf625a` after Calendar spacing PR #90 merged. The conflict resolution preserves main’s `flex w-full items-center justify-center p-2` Calendar wrapper and this PR’s shared toasterOffset configuration. The PR contains only the Toast changes in one file. ## Validation The rebased branch passed `npm run lint`, `npm run typecheck`, `npm run check:lockfile`, `npm run build` (87 generated pages), and `git diff --check`. The resolved component-studio.tsx is identical to the previously browser-tested staging version, which confirmed phone toast bounds inside the device screen. GitHub CI and maintainer approval remain the merge gates. ## Visual Demonstration 
Summary
The Calendar Card demo no longer imposes a 512px minimum height or a second layer of desktop padding. The studio gives this demo its own small inset, allowing the existing responsive card to fit inside the phone screen.
Related Issue
Closes #79
Type of Change
Component(s) Affected
src/components/showcase/component-studio.tsxEngineering Quality Checklist
Validation
Verified the calendar fits the phone preview without a scrollbar: client and scroll height both measured 705px. Checked tablet layout.
The integrated
codex/stagingtree containing this PR passednpm run lint,npm run typecheck,npm run build,npm run check:lockfile, registry synchronization, andgit diff --check. Individual GitHub CI checks remain the merge gate.Integration Note
The toast-containment PR for #81 touches the adjacent Toaster line in this wrapper. Both fixes are resolved together on staging; update the remaining branch after the first PR merges.
Visual Demonstration
Screenshots were captured from integrated staging.
Review follow-up
Re-signed the Calendar-only PR history. Toast changes continue separately in #100. A temporary base change caused the existing auto-merge to merge #92 into this issue branch; that branch update was reversed, restoring this PR to its Calendar-only head a53d9fe. Both active PRs target main. Whichever merges second requires rebasing onto main to preserve the adjacent wrapper and toaster changes; staging already validates their combined result.