Skip to content

Dev#30

Closed
davidgaspardev wants to merge 10 commits into
mainfrom
dev
Closed

Dev#30
davidgaspardev wants to merge 10 commits into
mainfrom
dev

Conversation

@davidgaspardev

Copy link
Copy Markdown
Owner

No description provided.

@davidgaspardev davidgaspardev requested a review from Copilot October 6, 2025 03:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the library from "cBytes" to "bytekit" throughout the codebase. The changes update all references to use the new naming convention and improve consistency in the API design.

  • Updates all #include <cbytes.h> statements to #include <bytekit.h>
  • Renames header guard and function signatures to use consistent byte_t types
  • Adds a new test target for the equal function with conditional compilation

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/test_equal.c Updates include statement and adds conditional main function for standalone testing
tests/test_copy.c Updates include statement to use new library name
tests/main.c Updates include statement to use new library name
tests/length_test.c Updates include statement to use new library name
tests/index_of_test.c Updates include statement to use new library name
tests/copy_test.c Updates include statement to use new library name
src/bytekit.h Renames header guard, removes ubyte_t typedef, and standardizes type usage
src/bytekit.c Updates include statement and function signature
README.md Updates library name and improves documentation formatting
Makefile Updates library name references and adds new test target

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/bytekit.h Outdated
Comment on lines +9 to +10
typedef byte_t *bytes_t;
typedef const byte_t *cbytes_t;

Copilot AI Oct 6, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The typedef byte_t *bytes_t creates a redundant type alias. Since byte_t is already defined as char, this is equivalent to char *bytes_t, which could be confusing. Consider using char * directly or renaming to be more descriptive like byte_array_t.

Copilot uses AI. Check for mistakes.
Accepted main's version for all conflicts — Google style (2-space indent,
pointer alignment, 80-col limit) replaces the older 4-space style in dev.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants