Skip to content

hatch_build.py: install the interface's and the plugin's dependencies when absent #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
echarles merged 2 commits into from
Sep 26, 2026
Merged

hatch_build.py: install the interface's and the plugin's dependencies when absent #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89c68e5
hatch_build.py: install the interface's and the plugin's dependencies…
echarles Sep 26, 2026
b330618
hatch_build.py: the plugin is a workspace member when there is a work…
echarles Sep 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion hatch_build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,24 @@ def initialize(self, version: str, build_data: dict) -> None: # noqa: ARG002
f"The wheel needs the built {' and '.join(missing)} under share/, and npm is not "
"on PATH to build them. Run `make build` first, or set DATALAYER_DECKS_SKIP_JS=1."
)
if not (ROOT / "node_modules").is_dir() and not (ROOT.parent.parent.parent / "node_modules").is_dir():
workspace = ROOT.parent.parent.parent / "node_modules"
if not (ROOT / "node_modules").is_dir() and not workspace.is_dir():
subprocess.run([npm, "install"], cwd=ROOT, check=True)
# The interface (app/) is a package of its own, never a workspace
# member: nothing hoists its dependencies, and its bundler has to be
# its own -- after a `git clean`, app/ otherwise resolves whatever
# rsbuild the workspace hoisted, which is not the one it was written
# against. The plugin is a workspace member when there is a workspace
# (hoisted, nothing to install: `npm install` inside a member would
# redirect to the whole workspace) and a package of its own in a plain
# checkout, where CI installs it too.
own = [ROOT / "app"]
if not workspace.is_dir():
own.append(ROOT / "plugins" / "ai-agents")
for package in own:
if not (package / "node_modules").is_dir():
self.app.display_info(f"Installing {package.relative_to(ROOT)}'s dependencies ...")
subprocess.run([npm, "install", "--no-audit", "--no-fund"], cwd=package, check=True)
self.app.display_info(f"Building the {' and '.join(missing)} into share/ ...")
subprocess.run([npm, "run", "build:all"], cwd=ROOT, check=True)
for name, marker in (("interface", APP), ("container", CONTAINER)):
Expand Down
Loading