Repository navigation
hatch_build.py: install the interface's and the plugin's dependencies when absent - #4
Merged
Merged
Conversation
… when absent They are packages of their own, not workspace members, so nothing hoists them; after a git clean the interface resolved whatever rsbuild the workspace hoisted (1.7, with an SWC plugin mismatch: 'The version of the SWC Wasm plugin you're using might not be compatible') instead of the 2.x it declares. Installed when node_modules is missing, as CI does. Proven from a clean export with app/node_modules wiped: the wheel builds and carries both halves.
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved issues were identified.
Review effort: Lite
Findings: None
What changed in this PR
Updates the Hatch build hook so clean wheel builds install missing dependencies for the standalone interface and AI-agents plugin.
Changes:
- Installs
app/dependencies when absent. - Installs
plugins/ai-agents/dependencies when absent. - Preserves the existing JavaScript build flow.
| File | Description |
|---|---|
hatch_build.py |
Adds conditional dependency installation for the interface and plugin packages. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…space plugins/* is in the workspace's globs, so its dependencies are hoisted and an npm install inside it would redirect to the whole workspace; only a plain checkout installs it. The interface is never a member.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make publish-pypi(and anypython -m buildafter agit clean) failed in the interface build: The version of the SWC Wasm plugin you're using might not be compatible with builtin:swc-loader.app/andplugins/ai-agents/are packages of their own, not workspace members, so nothing hoists their dependencies; withapp/node_modulesgone, the interface resolved the rsbuild the workspace hoisted (1.7) instead of the 2.x it declares. The hook now installs each one's dependencies when itsnode_modulesis missing, which is what CI does. Proven from a clean export withapp/node_moduleswiped: the wheel builds and carries both halves.Note that a release no longer needs
make publish-pypi: pushing the tag is the release (RELEASE.md).