Skip to content

Fix string-normalized Result expectations #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
monrog2 merged 1 commit into from
Aug 18, 2026
Merged

Fix string-normalized Result expectations #433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tests/checks/equipment_disk_limits_exceeded/test_equipment_disk_limits_exceeded.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@
{f182x_api: read_data(dir, "faultInst_pos.json")},
script.FAIL_UF,
[
["1", "101", "F1820", 98, "Disk usage for /mnt/ifc/log is high on node 101 of fabric POD1 with a hostname leaf1"],
["1", "102", "F1821", 97, "Disk usage for /mnt/ifc/cfg is high on node 102 of fabric POD1 with a hostname leaf2"],
["1", "104", "F1821", 100, "Disk usage for / is high on node 104 of fabric POD1 with a hostname LEAF-104"],
["1", "101", "F1820", "98", "Disk usage for /mnt/ifc/log is high on node 101 of fabric POD1 with a hostname leaf1"],
["1", "102", "F1821", "97", "Disk usage for /mnt/ifc/cfg is high on node 102 of fabric POD1 with a hostname leaf2"],
["1", "104", "F1821", "100", "Disk usage for / is high on node 104 of fabric POD1 with a hostname LEAF-104"],
],
[[
"topology/pod-1/node-[103]/sys/eqptcapacity/fspartition-ifc:cfg/fault-F1821",
Expand All @@ -41,7 +41,7 @@
(
{f182x_api: read_data(dir, "faultInst_compact.json")},
script.FAIL_UF,
[["1", "107", "F1820", 81, "Disk usage for /mnt/ifc/cfg is above normal"]],
[["1", "107", "F1820", "81", "Disk usage for /mnt/ifc/cfg is above normal"]],
[],
),
],
Expand All @@ -58,4 +58,4 @@ def test_logic(
assert result.data == expected_data
assert result.unformatted_data == expected_unformatted_data
for row in result.data:
assert isinstance(row[3], int)
assert isinstance(row[3], str)
2 changes: 1 addition & 1 deletion .../checks/n9k_c93180yc_fx3_switch_memory_check/test_n9k_c93180yc_fx3_switch_memory_check.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ def make_fx3_nodes(count):
'One or more switches with less than 32GB of memory may experience service instability. '
'Upgrade the switch memory to at least 32GB.'
),
[["101", "leaf101", "N9K-C93180YC-FX3", 16.0]],
[["101", "leaf101", "N9K-C93180YC-FX3", "16.0"]],
),
],
)
Expand Down
Loading