Skip to content

Fix data types #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
manke-cubert wants to merge 2 commits into from
Closed

Fix data types #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9a7e7e
Fix data types; Add missing allow_overwrite parameter to SaveArgs
manke-cubert Mar 23, 2026
712dabd
Remove allow_fragmentation from SaveArgs
manke-cubert Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions cuvis/FileWriteSettings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
@dataclass
class PanSharpeningSettings(object):
channel_selection: str = "all"
spectra_multiplier: int = 1
spectra_multiplier: float = 1
pan_scale: float = 0.0
pan_sharpening_interpolation_type: PanSharpeningInterpolationType = (
PanSharpeningInterpolationType.Linear
Expand All @@ -36,7 +36,7 @@ def _get_internal(self) -> cuvis_il.cuvis_pansharpening_settings_t:
ps = cuvis_il.cuvis_pansharpening_settings_t()
ps.channel_selection = self.channel_selection
ps.spectra_multiplier = self.spectra_multiplier
ps.pan_scale = float(self.pan_scale)
ps.pan_scale = self.pan_scale
ps.pan_interpolation_type = internal.__CuvisPanSharpeningInterpolationType__[
self.pan_sharpening_interpolation_type
]
Expand Down Expand Up @@ -325,8 +325,8 @@ def _from_internal(
@dataclass
class SaveArgs(GeneralExportSettings):
merge_mode: SessionMergeMode = SessionMergeMode.Default
allow_fragmentation: bool = False
Copy link
Copy Markdown
Contributor

@schmid-ls schmid-ls Mar 24, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has the “allow_fragmentation” option been removed in general? The option was still used in the Python example => will fail now.

Copy link
Copy Markdown
Collaborator

@birkholz-cubert birkholz-cubert Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so allow_fragmentation was replaced my merge mode as an enum

allow_drop: bool = False
allow_overwrite: bool = False
allow_session_file: bool = True
allow_info_file: bool = True
operation_mode: OperationMode = OperationMode.Software
Expand All @@ -341,6 +341,7 @@ def _get_internal(self):
sa = cuvis_il.cuvis_save_args_t()
sa.merge_mode = internal.__CuvisSessionMergeMode__[self.merge_mode]
sa.allow_drop = int(self.allow_drop)
sa.allow_overwrite = int(self.allow_overwrite)
sa.allow_session_file = int(self.allow_session_file)
sa.allow_info_file = int(self.allow_info_file)
sa.operation_mode = internal.__CuvisOperationMode__[self.operation_mode]
Expand All @@ -362,7 +363,6 @@ def _from_internal(
**ge.__dict__,
allow_overwrite=bool(sa.allow_overwrite),
merge_mode=internal.__SessionMergeMode__[sa.merge_mode],
allow_fragmentation=bool(sa.allow_fragmentation),
allow_drop=bool(sa.allow_drop),
allow_session_file=bool(sa.allow_session_file),
allow_info_file=bool(sa.allow_info_file),
Expand Down
2 changes: 1 addition & 1 deletion cuvis/cuvis_aux.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ def _from_internal(cls, gps):
@dataclass(frozen=True)
class SensorInfo(object):
averages: int
temperature: int
temperature: float
gain: float
readout_time: datetime.datetime
width: int
Expand Down
Loading