Fix data types#84
Closed
manke-cubert wants to merge 2 commits intomainfrom
Closed
Conversation
Contributor
manke-cubert
commented
Mar 23, 2026
manke-cubert
commented
- Add missing allow_overwrite parameter to SaveArgs
- Change Sensor temperature data type to float (SensorInfo)
- Change spectral multiplier data type to float (PanSharpeningSettings)
schmid-ls
reviewed
Mar 24, 2026
| @dataclass | ||
| class SaveArgs(GeneralExportSettings): | ||
| merge_mode: SessionMergeMode = SessionMergeMode.Default | ||
| allow_fragmentation: bool = False |
Contributor
There was a problem hiding this comment.
Has the “allow_fragmentation” option been removed in general? The option was still used in the Python example => will fail now.
Collaborator
There was a problem hiding this comment.
so allow_fragmentation was replaced my merge mode as an enum
schmid-ls
approved these changes
Apr 13, 2026
manke-cubert
force-pushed
the
feature/fix_types
branch
from
5d353ae to
712dabd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.