-
Notifications
You must be signed in to change notification settings - Fork 2.1k
refactor(linter): migrate @cubejs-backend/linter from ESLint to oxlint #11790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
1b3232d
60b9b01
9c2ca65
090a7b1
0934166
f971914
8d9231b
332bbd2
ac18b10
fdcd3a8
1d1aab4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| // The rule set lives in the @cubejs-backend/linter package so it stays a publishable, | ||
| // reviewable unit; this file adds the repo-wide ignores. | ||
| // | ||
| // `yarn lint` runs bare `oxlint`: passing -c/--config would disable nested config | ||
| // discovery, and packages/cubejs-client-{dx,react} rely on it. | ||
| { | ||
| "$schema": "./node_modules/oxlint/configuration_schema.json", | ||
| "extends": ["./packages/cubejs-linter/.oxlintrc.json"], | ||
| "env": { | ||
| "node": true, | ||
| "es6": true | ||
| }, | ||
| "ignorePatterns": [ | ||
| "dist/", | ||
| "lib/", | ||
| "build/", | ||
| "coverage/", | ||
| "gen/", | ||
| "**/*.d.ts", | ||
| "docs/", | ||
| "docs-mintlify/", | ||
| "examples/", | ||
| "rust/cubesql/", | ||
| // never covered by the ESLint setup this replaced | ||
| "packages/cubejs-testing/cypress/", | ||
| "packages/cubejs-testing/birdbox-fixtures/", | ||
| // a mongosh script, not Node: `db` is a shell global | ||
| "packages/cubejs-mongobi-driver/test/mongo-init.js", | ||
| // vendored Thrift output | ||
| "packages/cubejs-hive-driver/idl/", | ||
| // generated flatbuffers accessors | ||
| "packages/cubejs-cubestore-driver/codegen/", | ||
| // generated ANTLR parsers and SQL fixtures | ||
| "packages/cubejs-schema-compiler/src/parser/GenericSql*.ts", | ||
| "packages/cubejs-schema-compiler/src/parser/Python3*.ts", | ||
| "packages/cubejs-schema-compiler/test/unit/fixtures/" | ||
| ] | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,11 +19,12 @@ | |
| "watch": "rollup -c -w", | ||
| "watch-local": "CUBEJS_API_URL=http://localhost:6020/cubejs-api/v1 rollup -c -w", | ||
| "lint:npm": "yarn npmPkgJsonLint packages/*/package.json rust/package.json", | ||
| "lint": "yarn lint:npm && yarn lerna run lint", | ||
| "lint:fix": "lerna run lint:fix", | ||
| "lint": "yarn lint:npm && yarn lint:js", | ||
| "lint:fix": "oxlint --fix", | ||
| "tsc": "tsc --build", | ||
| "tsc:watch": "tsc --build --watch", | ||
| "clean": "rimraf packages/*/{tsconfig.tsbuildinfo,lib,dist} packages/cubejs-testing/cypress/{tsconfig.tsbuildinfo,dist}" | ||
| "clean": "rimraf packages/*/{tsconfig.tsbuildinfo,lib,dist} packages/cubejs-testing/cypress/{tsconfig.tsbuildinfo,dist}", | ||
| "lint:js": "oxlint" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not a regression (ESLint exited 0 on warnings too), but the consolidation makes a ratchet cheap and more valuable than before: with one root invocation and a known baseline of 123 warnings, |
||
| }, | ||
| "author": "Cube Dev, Inc.", | ||
| "dependencies": { | ||
|
|
@@ -46,14 +47,12 @@ | |
| "@rollup/plugin-commonjs": "^17.1.0", | ||
| "@rollup/plugin-json": "^6.1.0", | ||
| "@rollup/plugin-node-resolve": "^11.2.0", | ||
| "@typescript-eslint/eslint-plugin": "^8.46.0", | ||
| "@typescript-eslint/parser": "^8.46.0", | ||
| "eslint": "^8.57.1", | ||
| "@types/fs-extra": "^11.0.4", | ||
| "@types/jest": "^29", | ||
| "husky": "^5.0.4", | ||
| "is-ci": "^2.0.0", | ||
| "npm-package-json-lint": "^5.1.0", | ||
| "oxlint": "^1.82.0", | ||
| "postcss": "^8.2.8", | ||
| "prettier": "^2.0.5", | ||
| "rimraf": "^3.0.2", | ||
|
|
||
This file was deleted.
Uh oh!
There was an error while loading. Please reload this page.