refactor(linter): migrate @cubejs-backend/linter from ESLint to oxlint

[ovr]

Check List

• Tests have been run in packages where changes have been made if available
• Linter has been run for changed code
• Tests for the changes have been added if not covered yet
• Docs have been added / updated if required

Description of Changes Made

@cubejs-backend/linter now ships an oxlint config instead of an eslintrc one: airbnb-base.json is a mechanical port of the old airbnb-base + typescript-eslint rule set (generated from eslint --print-config, so it is verifiable rather than hand-transcribed) and .oxlintrc.json holds the deliberate departures with a reason stated for each; a repo-root .oxlintrc.json extends it and owns the ignore list, which replaces the 49 per-package lint scripts and 46 eslintConfig blocks with one root oxlint run (2.7s over 873 files, versus 49 sequential ESLint 8 processes in CI), and gets us off a toolchain that is out of runway — ESLint 8.57.1 is unsupported, and #11767 already had to shuffle four formatting rules into @stylistic/eslint-plugin-ts because typescript-eslint 8 dropped them. Because oxlint implements no formatting rules, @stylistic/eslint-plugin is loaded via jsPlugins to keep the 48 whitespace rules airbnb-base relies on; of the 192 rules the old config resolved to, 125 map natively with identical options, 48 move to @stylistic/*, 8 are renamed, and the 14 with no equivalent are listed at the top of airbnb-base.json. Parity was verified by diffing per-file diagnostics against an ESLint run on origin/master — of the 50 previously-linted files that report no-unused-vars, 46 match exactly and the 4 that differ are oxlint being more lenient — leaving 0 errors and 149 warnings against a baseline of 0 errors and 178 warnings. The source changes are oxlint --fix output and are all formatting: @stylistic understands TypeScript syntax where ESLint's core rules did not, so indent in generic argument lists, object-curly-spacing/quote-props in type literals and space-before-blocks on interface bodies now apply; four files carry a hand-written eslint-disable for intentional code. Two things are deliberately left for follow-up: eslint-plugin-import never actually ran (no TypeScript resolver, import/no-unresolved off), so import/no-cycle and friends fire for the first time and report 173 real dependency cycles plus 2 duplicate exports in client-core — kept off for now — and categories.correctness is pinned off so this change stays a faithful port.

Client packages are covered by nested configs for cubejs-client-react and cubejs-client-dx; cubejs-client-vue3 stays on ESLint because oxlint cannot parse Vue SFCs.

🤖 Generated with Claude Code

[claude]

Claude finished @ovr's task in 1m 52s —— View job

---

Re-review of 7ab3e4b (yarn.lock): lockfile checks out — no new findings, 7 prior still open (2 medium, 5 low)

Full re-review

• Review the new commit 7ab3e4b
• Verify the lockfile claims against the package.json state
• Re-check prior findings MUTEX for requests #2–ResultSet.normalizePivotConfig() fix #6, Introduce Query class in ResultSet #8, Add a method to ResultSet to retrieve the format for query member  #9
• Resolve stale threads & post

The commit does what it says

3f9579d..7ab3e4b is yarn.lock only, 17 insertions / 296 deletions. I verified the substantive claims against the tree rather than the message:

• eslint is gone. No eslint@… entry remains in yarn.lock — the only eslint* top-level keys left are eslint-config-airbnb{,-base}, eslint-plugin-jsx-a11y, eslint-plugin-react (all reachable only from packages/cubejs-playground), plus eslint-scope@5.1.1 and eslint-visitor-keys@^3/^4, which are pulled by non-ESLint consumers. No eslint binary in the tree, matching the message.
• No orphaned plugin trees. @typescript-eslint/* is down to a single @typescript-eslint/types@^8.56.0 (transitive under @stylistic/eslint-plugin@5.10.0); eslint-plugin-{import,node,unicorn,jest} are absent entirely — correct, since oxlint reimplements those natively.
• The new deps resolve. @stylistic/eslint-plugin@5.10.0 and the full @oxlint/binding-*@1.82.0 platform set are present, so the jsPlugins wiring has something to load on every CI platform.
• @cubejs-backend/linter@1.7.35 is still a devDependency of 46 packages even though nothing in those packages runs lint anymore. Harmless (devDeps don't reach consumers, and the workspace resolves it locally), just worth a sweep whenever the follow-ups land.

The eslint-config-airbnb / jsx-a11y / react survivors in cubejs-playground are called out in the commit message as a follow-up, and the reasoning is right: that package has no lint script, is in oxlint's ignorePatterns, and its only ESLint runner came transitively from the old @cubejs-backend/linter. They are now a config and two plugins with no engine — dead, but inert.

One new hygiene note (not worth an inline comment)

Root package.json:58 still carries "prettier": "^2.0.5", and it is now provably unused: no root .prettierrc, no script in any workspace package invokes it, and the two .prettierrc files left in the tree (packages/cubejs-playground, packages/cubejs-client-vue3) belong to packages that don't declare prettier. 3f9579d deleted the one .prettierrc that had a real workflow behind it. Since this commit's whole job is settling dependency state after the migration, dropping root prettier — together with the .prettierrc entries still in the paths: filters at push.yml:15,34 and master.yml:9, which match no root file — would finish the cleanup.

Prior findings — all still open

#	Severity	Where	Status
2	Medium	packages/cubejs-linter/airbnb-base.json:535	Still applies. Core no-shadow: "error" unqualified, TS override doesn't remap it, still absent from the "no equivalent" list
6	Medium	packages/cubejs-linter/.oxlintrc.json:23	Still applies. import/named still on and still build-order dependent
3	Low	packages/cubejs-backend-maven/src/maven.ts:30-40	Still applies. Live chain one call per line; commented block still .ele().txt().up()
4	Low	package.json:27	Still applies. "lint:js": "oxlint", no --max-warnings
5	Low	packages/cubejs-hive-driver/package.json:15	Still applies. "scripts": {} still there
8	Low	query-builder.service.ts:179-184	Still applies. Inverted disableHeuristics()/enableHeuristics()
9	Low	query-members.ts:47	Still applies. No CI coverage for ngx

Re-affirmed all seven rather than posting duplicates. Findings #1 and #7 remain resolved. No human threads touched.

Caveat

Still no node_modules in this sandbox, so I could not execute yarn install --frozen-lockfile, yarn lint or oxlint. The "exit 0, 78.8s", "frozen-lockfile passes" and "0 errors, 149 warnings" numbers are taken as stated; everything above is from reading yarn.lock and the package manifests directly.

• branch `migrate-linter-to-oxlint`

[codecov]

Codecov Report

❌ Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.22%. Comparing base (cdcd03a) to head (1d1aab4).
⚠️ Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
packages/cubejs-backend-cloud/src/cloud.ts	0.00%	1 Missing ⚠️
packages/cubejs-backend-shared/src/promises.ts	87.50%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #11790      +/-   ##
==========================================
- Coverage   84.67%   80.22%   -4.46%     
==========================================
  Files         261      500     +239     
  Lines       86451   105649   +19198     
  Branches        0     3885    +3885     
==========================================
+ Hits        73204    84752   +11548     
- Misses      13247    20348    +7101     
- Partials        0      549     +549     

Flag	Coverage Δ
cube-backend	60.15% <88.88%> (?)
cubesql	84.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[claude]

Claude finished @ovr's task in 3m 32s —— View job

---

Re-review of 9e873e3 (playground → oxlint): 1 high, 2 medium, 1 low new; 7 prior still open (2 medium, 5 low). yarn lint is red at HEAD.

Full re-review

• Review new commit 9e873e3
• Verify airbnb-react.json extraction / config wiring
• Spot-check non-mechanical source changes
• Re-check prior findings
• Resolve stale threads & post

The headline

The commit message says it plainly — INCOMPLETE: yarn lint is red, 279 errors left — and taking packages/cubejs-playground/ off the root ignore list in the same commit means that redness is now the PR's state, not the package's. The Oxlint step in Build (push.yml:201-202) runs bare oxlint over the whole repo, so this branch cannot go green until the remaining no-shadow (146), no-nested-ternary (30), react/no-array-index-key (13), no-use-before-define (12), jsx-a11y (9) and no-throw-literal (5) are dealt with. Turning those six "off" in the package's own config with a TODO would let the ~1000 already-fixed findings become enforceable now rather than parking them behind the 279 — details inline. A visible instance of the leftovers, in case it's a useful smoke test: QueryBuilderChart.tsx:30 has a double blank line against @stylistic/no-multiple-empty-lines: max 1.

What's good

• Hoisting the React rule set into @cubejs-backend/linter/airbnb-react.json is the right call — cubejs-client-react/.oxlintrc.json drops from 928 lines to 17, and both React packages now share one set. The "no oxlint equivalent, not carried over" header lists the PropTypes/class-component family, matching airbnb-base.json's convention.
• Verifying equivalence by linting a probe .tsx with option-dependent violations (max-len 120, jsx-wrap-multilines, anchor-is-valid with components: ["Link"]) is the right method given --print-config doesn't resolve extends — that's the failure mode that would have made a config diff meaningless.
• The three departures are each justified by a count and a reason, and the overrides-outranks-top-level-rules note is exactly the kind of thing that costs the next person an hour. The --fix-suggestions warning (no-void rewriting void runQuery(); → undefined;, silently deleting the call) is a genuinely dangerous fixer and worth having recorded in the history.
• I read every non-whitespace change in the 127 files (git diff --ignore-all-space 7ab3e4b 9e873e3). The hand-fixed set is what the message claims: 22 catch (e: any) → catch { (all bindings genuinely unused), let → const across the react-aria drag/drop code, name: name → name, and the dead getJSONValidator removal — I confirmed no remaining reference to it and that convertGraphQLToJsonQuery is still used by getGraphQLValidator, so the import survives correctly. The CHART_HEIGHT/maxHeight removal is safe: maxHeight was destructured but never read even before this commit, and no caller passes it (QueryBuilderInternals.tsx:128 is the only call site).
• The throw '' sites are left alone, which is right — throw ''; // do not show any error message is load-bearing for the ui-kit form validators.

New findings

#	Severity	Where	Issue
10	High	packages/cubejs-playground/.oxlintrc.json:1	Package un-ignored while 279 errors remain, so yarn lint:js / the Oxlint CI step is red for the whole PR
11	Medium	packages/cubejs-playground/package.json:80	Three devDeps removed without regenerating yarn.lock; the Build job's "Non empty changeset" guard trips on a lockfile yarn wants to prune
12	Medium	packages/cubejs-linter/package.json:20	airbnb-react.json missing from files — the new shared rule set isn't in the published tarball
13	Low	QueryBuilderInternals.tsx:44	prefer-arrow-callback stripped the names off 7 memo/forwardRef components; they now show as Anonymous in DevTools and component stacks

Prior findings — all seven still open

#	Severity	Where	Status
2	Medium	packages/cubejs-linter/airbnb-base.json:535	Still applies. no-shadow: "error" unqualified; not in airbnb-react.json's or airbnb-base.json's off-list either. Note this is now the single largest blocker in the playground count above — 146 of the 279
6	Medium	packages/cubejs-linter/.oxlintrc.json:23	Still applies. import/named still "error" (airbnb-base.json:418), still build-order dependent
3	Low	packages/cubejs-backend-maven/src/maven.ts:30-40	Still applies. Unchanged; commented block still .ele().txt().up()
4	Low	package.json:27	Still applies. "lint:js": "oxlint", no --max-warnings
5	Low	packages/cubejs-hive-driver/package.json:15	Still applies. "scripts": {}
8	Low	query-builder.service.ts:179-184	Still applies. Inverted disableHeuristics()/enableHeuristics()
9	Low	query-members.ts:47	Still applies. No CI coverage for ngx

Re-affirmed all seven rather than posting duplicates. #1 and #7 remain resolved; nothing new became stale, so no threads were resolved this round. No human threads touched.

Smaller notes

• Several --fix outputs now have arguments hanging at the wrong indent — FilterGroup.tsx:28-35 (), \n [members]);), QueryBuilder.tsx:39-44, QueryBuilderInternals.tsx:83-84, and useCommitPress(() => runQuery(),\n true);. Cosmetically worse than what it replaced, and @stylistic/indent apparently accepts both, so it's a "fixer produced this" artefact rather than a rule anyone would ask for.
• MemberDropdown.tsx:60-65's .map((cube) => (\n { is the same shape — arrow-body-style removing the return but leaving the object literal on its own lines.
• QueryBuilderChartProps.maxHeight is now a prop nothing reads; since the CHART_HEIGHT default went away with it, dropping it from the interface would keep callers honest.
• packages/cubejs-playground/.prettierrc survives, same as cubejs-client-vue3's — and .prettierrc is still in the paths: filter of both workflows plus root prettier: ^2.0.5 in devDependencies. This commit is the one that makes playground's copy provably unused.
• PR description still says playground was "never covered" and cubejs-client-vue3 "stays on ESLint"; both are now out of date, and the description is what lands in the squash commit.
• Same caveat as the previous four passes: no node_modules in this sandbox, so I can't execute oxlint. The "1372 → 279", "10 identical probe findings", "yarn unit 1 passed" and "160 pre-existing tsc errors" numbers are taken as stated; everything above is from reading the tree. Build, Drivers tests, Rust and Build native were all still in progress when I finished; nothing had failed yet.

• branch `migrate-linter-to-oxlint`

[claude]

prefer-arrow-callback (airbnb's default is allowNamedFunctions: false) rewrote every memo(function Name() {...}) / forwardRef(function Name() {...}) in this package into an anonymous arrow: AccordionDetails, AccordionItemIcon, AccordionItemContent, Arrow, CopyIcon, OrderListItem and this one. The named function expression was the mechanism that gave these components a name — memo() and forwardRef() wrappers have no variable-name inference, so they now render as Anonymous/ForwardRef in React DevTools and in component stacks in error boundaries and warnings, which is the main tool for reading this UI's tree.

Since the whole point of that idiom is the name, allowNamedFunctions: true in the package's own config (or in airbnb-react.json, since it's React-specific) would let the autofix keep it, and it's the setting that matches how these files were written:

"prefer-arrow-callback": ["error", { "allowNamedFunctions": true }]

[claude]

Claude finished @ovr's task in 6m 17s —— View job

---

Re-review of f971914 (playground errors cleared): findings #10 and #11 resolved — 2 new (1 medium, 1 low), 6 prior still open (2 medium, 4 low)

Full re-review

• Review new commit f971914
• Verify finding Update normalizePivotConfig method #10 (red lint) is actually cleared
• Trace every non-mechanical source change for semantic equivalence
• Re-check prior findings
• Resolve stale threads & post

Findings #10 and #11 are resolved

f971914 is the other half of 0934166: the package's own config no longer parks any rule, and the six rule families that were red (no-shadow 142, no-nested-ternary 29, react/no-array-index-key 13, no-use-before-define 12, jsx-a11y 9, no-throw-literal 5) are all handled in the tree rather than switched off. The only rule the config gains is jsx-a11y/anchor-is-valid with components: [], and the reason recorded there is right — @cube-dev/ui-kit's Link is Omit<CubeButtonProps, 'ref'> driven by onPress, the rule can't distinguish it from react-router's by import, and dropping the list leaves real <a> checking intact. Resolved that thread.

0934166 now also carries the yarn.lock regeneration — no eslint-config-airbnb, eslint-plugin-jsx-a11y or eslint-plugin-react entries survive, so the Build job's "Non empty changeset" guard has nothing to trip on. Resolved that thread too.

The rewrites hold up

I read all 899 changed lines and checked each non-mechanical one against its original. The ones with a real chance of drifting, and why they don't:

• ValuesInput.tsx suffix — the doubly-nested allowSuggestions && !suggestionError ? (!isSuggestionLoading ? Button : null) : (suggestionError && !hasError ? Grid : null) became three flat branches. I enumerated all eight combinations of the three booleans; every one lands on the same node.
• SidePanelCubeItem.tsx mapElements — const arrow → function declaration, moved below hierarchiesElementMap. Hoisting is what makes the useMemo above still able to call it, and the isFolderOpen ? true : X → isFolderOpen || X collapse in shownMembers is exact. The filterMembers inner shadow (usedMembers.filter((m) => …).includes(m)) was renamed on the inner binding only, which is the correct one — .includes(m) sits outside the inner arrow.
• hooks/query-builder.ts — the 30-odd updateQuery((query) => …) → (currentQuery) renames are the exact shape the commit message flags as having bitten the renamer, so I checked the shorthand returns specifically: every return { filters } became return { filters: currentFilters }, and none of the surviving shorthands resolve to a renamed binding. connectionId's IIFE-to-find collapse and the c1joined/c2joined comparator rewrite are both value-identical.
• QueryBuilderResults.tsx / QueryBuilderChart.tsx — isLoading ? (isExpanded ? A : undefined) : (outdated ? B : undefined) → two guarded branches; identical on all four combinations. {cond && <X/>} inside antd Space and ui-kit Flex is safe: React.Children normalises false to null before rc-util's toArray sees it, so no phantom ant-space-item appears.
• RollupDesigner.tsx cubeName, get-member-search-name.ts, TimeListMember.tsx definedGranularities, shared/helpers.ts w/h, ListCube.tsx icons, DatabaseForm.tsx, ListMember.tsx, MemberSection.tsx, PreAggregationStatus.tsx — all ternary-to-branch conversions I walked case by case; all equivalent.
• utils.ts:271 and grid/Flex.tsx:83 add an explicit return false / return undefined where the original fell off the end — same value, consistent-return satisfied.
• TableQueryRenderer.tsx:24 value == undefined → value == null: loose equality made these already identical.

The a11y additions are genuine fixes rather than rule-appeasement: rel="noreferrer" on three target="_blank" links, title on the Vizard iframe, aria-selected={false} on both role="option" drop indicators (correctly placed before the {...dropIndicatorProps} spread so the hook can still override it).

New findings

#	Severity	Where	Issue
14	Medium	QueryBuilderV2/QueryBuilder.tsx:138	props.children ? … : <Internals/> became props.children ?? <Internals/>; falsy-but-not-nullish children (the {cond && <X/>} idiom) now render an empty builder instead of the default UI
15	Low	components/FilterMember.tsx:235	key={value} on filter.values assumes dedup that validateQuery doesn't enforce; same at ValuesInput.tsx:360 where the tags are interactive

Prior findings — status

#	Severity	Where	Status
2	Medium	packages/cubejs-linter/airbnb-base.json:535	Still applies. no-shadow: "error" is still unqualified and still absent from the "no equivalent" list. This commit is the strongest evidence yet for documenting it: 142 of the 279 errors were no-shadow, and a good share are the TS-specific shapes ignoreTypeValueShadow existed for — type BuildRange vs the component, type Tab vs the Tab component, type QueryTabs vs the QueryTabs component
6	Medium	packages/cubejs-linter/.oxlintrc.json:23	Still applies. import/named still "error" (airbnb-base.json:418), still build-order dependent
3	Low	packages/cubejs-backend-maven/src/maven.ts:40	Still applies. Unchanged; commented block still .ele().txt().up()
4	Low	package.json:27	Still applies. "lint:js": "oxlint", no --max-warnings — and the baseline moved again (149 → 151), which is the drift the flag would catch
5	Low	packages/cubejs-hive-driver/package.json:15	Still applies. "scripts": {}
12	Low	packages/cubejs-linter/package.json:20	Still applies. files is [".oxlintrc.json", "airbnb-base.json"]; airbnb-react.json still isn't published
13	Low	QueryBuilderV2/QueryBuilderInternals.tsx:44	Still applies. No memo(function …) / forwardRef(function …) remains anywhere in the package; AccordionItemIcon and AccordionItemContent, both moved in this commit, are still anonymous arrows
8	Low	query-builder.service.ts:184	Still applies. Inverted disableHeuristics()/enableHeuristics()
9	Low	query-members.ts:47	Still applies. No CI coverage for ngx

Re-affirmed those rather than posting duplicates. #1, #7, #10 and #11 are resolved. No human threads touched.

Smaller notes

• rollup-designer/components/Settings.tsx deletes the 47-line BuildRange component. I confirmed it's genuinely dead (no reference anywhere in src/, and ucfirst was its only importer here) — but a UI component removal is a different kind of change from the rest of the commit and lands under "formatting, no-unused-vars, misc | ~40 | mechanical" in the table. Worth its own line. Its removal also makes the BuildRange → BuildRangeValue type rename above it unnecessary, since nothing shadows that name anymore.
• The react/no-array-index-key justification is copy-pasted verbatim five times across QueryBuilderFilters.tsx and LogicalFilter.tsx. Stating it once where the filters array is defined and leaving a bare // eslint-disable-next-line react/no-array-index-key at each site would read better; five identical paragraphs in two files is the kind of thing that goes stale unevenly.
• Settings/Settings.tsx:99 drops the <label> wrapper for aria-label="Limit". Correct for the rule and no association is lost (the label had no text of its own — "Limit" is the input's prefix), just noting it's a DOM change inside a positioned dropdown rather than an attribute-only fix.
• ButtonDropdown.tsx:87 satisfies the static-element-interaction rule with role="presentation" on a clickable <div>. That silences the rule by removing semantics rather than adding them; the click target is still not keyboard-reachable. Fine as a lint pass, not an a11y improvement.
• EditQueryDialogForm.tsx:26,55 and QueryBuilderSidePanel.tsx:384 turn throw 'Invalid query' into throw new Error(...). The complementError reasoning in the message is right that the truthy-.message branch returns oe itself, so consumers reading .message see the same string — the residual risk is any consumer that renders the error entry directly, which would now get an object. Cheap to confirm by opening the JSON editor with malformed input once.
• PR description is now stale on three counts: playground "never covered", cubejs-client-vue3 "stays on ESLint", and the follow-ups paragraph. It's what lands in the squash commit, so worth a refresh.
• Same caveat as the previous five passes: no node_modules in this checkout, so I could not execute oxlint. "0 errors, 2 warnings", "151 warnings repo-wide", "160 pre-existing tsc errors" and "yarn unit passes" are taken as stated. Build (which runs the Oxlint step), Drivers tests, Rust and Build native were all still in progress when I finished; nothing had failed.

• branch [`migrate-linter-to-oxlint`](https://github.com/cube-js/cube/tree/migrate-linter-to-oxlint)

[claude]

Claude finished @ovr's task in 2m 2s —— View job

---

Re-review of 8d9231b: all four fixes verified — findings #5, #12, #14, #15 resolved; #13 settled as author's call; 6 prior still open (2 medium, 4 low)

Full re-review

• Review new commit 8d9231b
• Verify the fixes for findings Add support for AWS Athena in JDBC driver #5, QueryRenderer: fix prop types warnings #12, Add imports in Vanilla Javascript example #14, ResourceRequest timeout on db connection problems #15
• Re-check prior open findings
• Resolve stale threads & post

The four fixes are correct

f971914..8d9231b is 5 files, 7 insertions / 5 deletions. Each change does what the message says:

• QueryBuilder.tsx:138 — back to props.children || <QueryBuilderInternals />. That restores the original truthiness fallback exactly, and || satisfies no-nested-ternary the same way ?? did. ✅
• ValuesInput.tsx:359 — [...new Set(values)].map((value) => …). Set preserves first-occurrence order, so the rendered order is unchanged for the (normal) duplicate-free case, and the index binding that no-array-index-key objected to is gone rather than laundered. The argument in the message is the load-bearing one: onRemove filters by value and already removed every copy, so a second identical tag was never independently actionable — collapsing them is closer to the real behaviour than rendering two. ✅
• FilterMember.tsx:235 — same shape, and the ?. → && swap is behaviour-preserving: undefined still yields undefined, and [] is truthy so the empty case still yields []. ✅
• packages/cubejs-linter/package.json:20 — airbnb-react.json added to files; the published tarball now carries the whole rule set. ✅
• packages/cubejs-hive-driver/package.json — orphaned "scripts": {} dropped; both manifests still parse. ✅

[...new Set(...)] needs downlevel iteration; playground's tsconfig.json is target: ES2020 with lib: [dom, esnext], so both spreads compile.

On #13 (prefer-arrow-callback / allowNamedFunctions): the reasoning for not taking it is fair and the trade-off is a matter of taste, so that's settled — your call. Worth knowing the cost is still real (anonymous entries in DevTools and in component stacks), and it's recoverable later either by allowNamedFunctions: true or by setting displayName on the handful of memo/forwardRef wrappers. I left the thread open only because I can't reply on it; treat it as closed.

One new note, low

#	Severity	Where	Issue
16	Low	FilterMember.tsx:235	[...new Set(x)] duplicates the package's existing uniqArray helper (QueryBuilderV2/utils/uniq-array.ts, already used at graphql-converters.ts:213,582); same at ValuesInput.tsx:359

Correction to the suggestion block I posted inline: the one-line uniqArray(...) form comes to 122 characters with the indent, which trips max-len: 120, so it needs to stay wrapped across two lines — and both files need the uniqArray import added. The point is only the helper, not the layout.

Prior findings — six still open

#	Severity	Where	Status
2	Medium	packages/cubejs-linter/airbnb-base.json:535	Still applies. no-shadow: "error" still unqualified, TS override doesn't remap it, still absent from the "no equivalent" list
6	Medium	packages/cubejs-linter/.oxlintrc.json:23	Still applies. import/named still "error" (airbnb-base.json:418), still build-order dependent
3	Low	packages/cubejs-backend-maven/src/maven.ts:30-40	Still applies. Live chain one call per line; commented block still .ele().txt().up()
4	Low	package.json:27	Still applies. "lint:js": "oxlint", no --max-warnings
8	Low	query-builder.service.ts:184	Still applies. Inverted disableHeuristics()/enableHeuristics()
9	Low	query-members.ts:47	Still applies. No CI coverage for ngx

Re-affirmed those rather than posting duplicates. Resolved the four threads this commit addressed (#5, #12, #14, #15); #1, #7, #10 and #11 remain resolved. No human threads touched.

Smaller notes

• PR description is still stale on three counts — playground "never covered", cubejs-client-vue3 "stays on ESLint because oxlint cannot parse Vue SFCs", and the follow-ups paragraph. It's what lands in the squash commit, so worth a refresh before merge.
• Same caveat as the previous six passes: no node_modules in this checkout, so I could not execute oxlint — the formatting of the new wrapped .map( in FilterMember.tsx (function-paren-newline: consistent, @stylistic/indent) reads fine to me but is unverified. Build (which runs the Oxlint step), Drivers tests, Rust and Build native were all in progress when I finished; nothing had failed, and Lint CI Workflows passed.

• branch [`migrate-linter-to-oxlint`](https://github.com/cube-js/cube/tree/migrate-linter-to-oxlint)

[claude]

Claude finished @ovr's task in 2m 43s —— View job

---

Re-review of 332bbd2, ac18b10, fdcd3a8: findings #2, #6, #8, #9, #16 all resolved — 1 new (low), 3 prior still open (all low)

Full re-review

• Review 332bbd2, ac18b10, fdcd3a8
• Verify findings MUTEX for requests #2, ResultSet.normalizePivotConfig() fix #6, Introduce Query class in ResultSet #8, Add a method to ResultSet to retrieve the format for query member  #9, Add dependency "@cubejs-backend/server-core" installs "@cubejs-backend" #16 are addressed
• Re-check remaining open findings
• Resolve stale threads & post

Five findings closed, and the reasoning behind each holds

• ResultSet.normalizePivotConfig() fix #6 import/named (332bbd2) — folded into the off-list, and the recorded reason is the right one: the rule's verdict depends on whether cubejs-client-core/dist exists, CI is the cold case (yarn install → lint:npm → lint:js, no build), and GRANULARITIES really is exported (client-core/src/time.ts re-exported from src/index.ts), so the warm-tree finding was a false positive. The eslint-disable-next-line import/named in cubejs-client-vue3/src/index.js goes away with it, which is the tell that the rule was never earning its keep. ✅
• MUTEX for requests #2 no-shadow (332bbd2) — documented rather than remapped, with an A/B against eslint 8.57.1 + typescript-eslint 8.46.0 showing core no-shadow already ignores type-over-value. That matches what the tree shows: the only no-shadow suppression left in ngx is MemberType.Order, which is the enum-member-over-imported-binding case the note says both linters report. ✅
• Introduce Query class in ResultSet #8 heuristics (ac18b10) — disableHeuristics() now sets _disableHeuristics = true, enableHeuristics() sets it false. Correct against all four gates in the file (lines 73, 118, 122, 129), and the field still initialises to false, so the default (heuristics on) is unchanged. ✅
• Add a method to ResultSet to retrieve the format for query member  #9 ngx CI coverage (fdcd3a8) — the new Build client-ngx step is placed after Oxlint, which is what keeps the lint run cold-tree and consistent with the import/named reasoning above. The build:client-core prerequisite is real and correctly ordered: ngx's tsconfig.json maps @cubejs-client/core → ../cubejs-client-core, resolved under moduleResolution: "node" via the top-level typings: dist/src/index.d.ts, which only build:client-core produces. ngx pins typescript@~5.4.5 for Angular 18 and yarn.lock carries both that and ~6.0.3, so the TS 6 migration doesn't reach into this build. ✅
• Add dependency "@cubejs-backend/server-core" installs "@cubejs-backend" #16 uniqArray (fdcd3a8) — helper used at both sites, imports added; Array.from(new Set(...)) is the same semantics as the spread it replaces, so the dedup argument from the previous round is unchanged. The wrapped form comes to 103 chars, under max-len: 120. ✅

New finding

#	Severity	Where	Issue
17	Low	packages/cubejs-linter/airbnb-base.json:13-23	The no-shadow paragraph was inserted inside the "no equivalent, deliberately not carried over" list, orphaning the no-dupe-args, no-octal, no-octal-escape entry below it; both it and the new import/named block are ~10 lines where two sentences carry the weight

Prior findings — three still open, all low

#	Severity	Where	Status
3	Low	packages/cubejs-backend-maven/src/maven.ts:30-40	Still applies. Live chain is one call per line; the commented block below still uses .ele().txt().up()
4	Low	package.json:27	Still applies. "lint:js": "oxlint", no --max-warnings
13	Low	QueryBuilderV2/QueryBuilderInternals.tsx:44	Settled as your call last round (prefer-arrow-callback / allowNamedFunctions); thread left open only because I can't reply on it

Resolved the five threads this round addressed (#2, #6, #8, #9, #16); #1, #5, #7, #10, #11, #12, #14, #15 remain resolved. No human threads touched.

Smaller notes

• The Build client-ngx step adds an ng build (plus a client-core tsc) to the job that gates every push. Worth knowing it's a couple of minutes on the critical path of a job otherwise named for linting — an acceptable price for the coverage, but if it starts hurting, a separate job would parallelise it.
• ngx's tsconfig.json sets outDir: "../../out-tsc/lib", and out-tsc isn't in any .gitignore. ng-packagr normally redirects output to its own build dir so nothing should appear, but if it ever does it lands untracked at the repo root. Harmless in CI (the changeset guard runs before this step) — it'd only bite local runs.
• PR description is still stale on three counts: playground "never covered", cubejs-client-vue3 "stays on ESLint because oxlint cannot parse Vue SFCs", and the import/named/follow-ups paragraph. It's what lands in the squash commit.
• Same caveat as the previous seven passes: no node_modules in this checkout, so I could not execute oxlint, ng build or the A/B against ESLint. The parity claims in airbnb-base.json's new note and the "0 errors" state are taken as stated; everything above is from reading the tree. CI was still in progress when I finished; nothing had failed.

• branch [`migrate-linter-to-oxlint`](https://github.com/cube-js/cube/tree/migrate-linter-to-oxlint)

[claude]

Documenting the remap is the right answer, but it landed inside the "no equivalent, deliberately not carried over" list rather than after it — no-dupe-args, no-octal, no-octal-escape -- parse errors under ESM/strict now sits below the paragraph (lines 24-25) and reads as if it belongs to the no-shadow discussion instead of to the list ten lines above it.

Moving the paragraph below the list would fix that, and it's also a chance to shorten it: the load-bearing sentences are "oxlint has no typescript/no-shadow" and "core no-shadow already behaves the way ignoreTypeValueShadow asked for, verified by A/B against eslint 8.57.1 + typescript-eslint 8.46.0". The per-shape enumeration is the evidence for the A/B, which belongs in the commit message where you already recorded it — the config only needs the conclusion.

Same shape in .oxlintrc.json:20-29: the import/named rationale is now 10 lines where the two that matter are "verdict depends on build state, and CI is the cold case" plus "GRANULARITIES is genuinely exported, so the warm-tree finding is a false positive".

[claude]

Claude finished @ovr's task in 1m 6s —— View job

---

Re-review of 1d1aab4 (comment trimming): comment-only, no semantic change — no new findings; 4 prior still open (all low), one of which this commit could have closed

Full re-review

• Review the new commit 1d1aab4
• Verify no code semantics changed alongside the comment edits
• Re-check prior open findings (ResultSet pivot methods documentation  #3, Self reference guard in schema compiler #4, Import cubejs from '@cubejs-client/core'; error #13, Athena: additions to docs, conditionally generating Athena-specific environment variables, adding to CLI help text #17)
• Resolve stale threads & post

The commit is comment-only, and I checked that it really is

fdcd3a8..1d1aab4 is 11 files, 12 insertions / 40 deletions. Reading each hunk: every removal is a comment line, and the only thing that could have been mistaken for code is EditQueryDialogForm.tsx:65, where throw ''; // do not show any error message loses its trailing comment — the statement is unchanged and the reason now sits on the line above it. No eslint-disable-next-line directive was dropped, no rule name altered, no key= expression touched.

It's the right set of cuts

• The three-way restatement of "extends merges rules/plugins/jsPlugins but not env/ignorePatterns" collapses to the single canonical statement in packages/cubejs-linter/.oxlintrc.json:7-9, which is where someone hits the surprise. Root .oxlintrc.json, both React configs and airbnb-react.json just do the restating now without narrating it.
• The react/no-array-index-key rationale goes from a two-line paragraph copy-pasted six times to a one-liner. It's still repeated six times, but a one-line repeat is cheap and each one is at the site it excuses.
• QueryBuilderResults.tsx:208,834 and graphql-converters.ts:57 lose comments that restated the line under them ([...Array(n)] is visibly a range; graphQLOperator's body is three lines).
• The two survivors that got shortened rather than deleted are the right ones to keep: MemberType.Order's "an enum member is not a binding" and EditQueryDialogForm's "async-validator only reads .message when truthy". Both encode a fact about an external library or the TS scoping model that the code cannot state itself, so deleting them would let the next edit re-break them.

Prior findings — four still open, all low

#	Where	Status
17	packages/cubejs-linter/airbnb-base.json:13-25	Still applies, and it's the one this commit was in the best position to close. The no-shadow paragraph is still lines 14-23 inside the "no equivalent, deliberately not carried over" list, with no-dupe-args, no-octal, no-octal-escape orphaned below it at lines 24-25. .oxlintrc.json:14-28 is the same shape — the import/no-cycle + import/named rationale is 15 lines. Not a correctness problem; just the two comments the trim pass skipped
3	packages/cubejs-backend-maven/src/maven.ts:30-40	Still applies. Live chain is one call per line; the commented block below still uses .ele().txt().up()
4	package.json:27	Still applies. "lint:js": "oxlint", no --max-warnings
13	QueryBuilderV2/QueryBuilderInternals.tsx:44	Settled as your call two rounds ago (prefer-arrow-callback / allowNamedFunctions); the thread is open only because I can't reply on it

Re-affirmed those rather than posting duplicates. Nothing became stale this round, so no threads were resolved; #1, #2, #5–#12, #14–#16 remain resolved. No human threads touched.

Smaller notes

• PR description is still stale on three counts: playground "never covered", cubejs-client-vue3 "stays on ESLint because oxlint cannot parse Vue SFCs", and the import/named/follow-ups paragraph. It's what lands in the squash commit, so worth a refresh before merge.
• Same caveat as the previous eight passes: no node_modules in this checkout, so I could not execute oxlint. Since this commit changes no code, the lint state is whatever fdcd3a8 had. CI at the time I finished: Lint CI Workflows and the labeler passed; Build (which runs the Oxlint step), Drivers tests, Rust and Build native were still in progress, nothing failed.

• branch [`migrate-linter-to-oxlint`](https://github.com/cube-js/cube/tree/migrate-linter-to-oxlint)