Skip to content

Guard 512-bit key tests against OpenSSL security level rejection #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
toddr-bot wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Guard 512-bit key tests against OpenSSL security level rejection #206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion t/keygen.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,5 +177,8 @@ plan tests => 29;
like($@, qr/at least 512 bits/, "generate_key croaks on 511-bit key size");

my $rsa = eval { Crypt::OpenSSL::RSA->generate_key(512) };
ok($rsa && !$@, "generate_key accepts 512-bit key size (minimum)");
SKIP: {
skip "OpenSSL rejects 512-bit keys at this security level", 1 if $@;
ok($rsa, "generate_key accepts 512-bit key size (minimum)");
}
}
8 changes: 6 additions & 2 deletions t/rsa.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,11 @@ sub _check_for_croak {
Crypt::OpenSSL::Random::random_seed("OpenSSL needs at least 32 bytes.");
Crypt::OpenSSL::RSA->import_random_seed();

is( Crypt::OpenSSL::RSA->generate_key(512)->size() * 8, 512, "512-bit key has correct size" );
SKIP: {
my $rsa_512 = eval { Crypt::OpenSSL::RSA->generate_key(512) };
skip "OpenSSL rejects 512-bit keys at this security level", 1 if $@;
is( $rsa_512->size() * 8, 512, "512-bit key has correct size" );
}

my $rsa = Crypt::OpenSSL::RSA->generate_key(2048);
is( $rsa->size() * 8, 2048, "2048-bit key has correct size" );
Expand Down Expand Up @@ -183,7 +187,7 @@ _check_for_croak(

# check subclassing

eval { Crypt::OpenSSL::RSA::Subpackage->generate_key(512); };
eval { Crypt::OpenSSL::RSA::Subpackage->generate_key(2048); };
ok( !$@, "subclass generate_key() succeeds" );

package Crypt::OpenSSL::RSA::Subpackage;
Expand Down
Loading