Guard 512-bit key tests against OpenSSL security level rejection#206
Draft
toddr-bot wants to merge 1 commit into
Draft
Guard 512-bit key tests against OpenSSL security level rejection#206toddr-bot wants to merge 1 commit into
toddr-bot wants to merge 1 commit into
Conversation
…ection Some OpenSSL builds (FIPS, high security levels) reject 512-bit RSA keys. Three test sites used 512-bit keygen without SKIP guards, which would crash the entire test file instead of gracefully skipping: - t/rsa.t: bare generate_key(512) with no eval protection - t/rsa.t: subclass test used 512-bit (switched to 2048-bit) - t/keygen.t: used eval but reported failure instead of SKIP Follows the pattern already established in t/error.t lines 131-136.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generate_key(512)int/rsa.twith eval/SKIP guard — previously would crash the entire test file on OpenSSL builds that reject 512-bit keys (FIPS mode, high security levels)t/keygen.t512-bit test from ok/fail to SKIP pattern when OpenSSL rejects the keyFollows the pattern already established in
t/error.tlines 131-136.Test plan
use_pkcs1_pss_paddingfrom unmerged PRs)Quality Report
Changes: 2 files changed, 10 insertions(+), 3 deletions(-)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan