Skip to content

fix(select): исправлена высота в BaseOption и Option для размеров optionsSize [DS-17210] #2232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dHIM24 wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −0
Open

fix(select): исправлена высота в BaseOption и Option для размеров optionsSize [DS-17210] #2232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/hungry-dryers-lead.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@alfalab/core-components-select': patch
---

- Исправлена поддержка `size={40}` в `Select`
- Проп `optionsSize` помечен как deprecated: размер пунктов списка определяется контентом
4 changes: 4 additions & 0 deletions packages/select/src/components/option/index.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@
}
}

.size-40 {
min-height: var(--size-xs-height);
}

.size-48 {
min-height: var(--size-s-height);
}
Expand Down
1 change: 1 addition & 0 deletions packages/select/src/typings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ export interface BaseSelectProps {

/**
* Размер пунктов меню
* @deprecated Управление размером пунктов меню через отдельный проп не поддерживается дизайн-контрактом. Размер пункта должен определяться его контентом.
*/
optionsSize?: 40 | 48 | 56 | 64 | 72;

Expand Down