Skip to content

fix(select): исправлена высота в BaseOption и Option для размеров optionsSize [DS-17210]#2232

Open
dHIM24 wants to merge 1 commit into
masterfrom
DS-17210
Open

fix(select): исправлена высота в BaseOption и Option для размеров optionsSize [DS-17210]#2232
dHIM24 wants to merge 1 commit into
masterfrom
DS-17210

Conversation

@dHIM24

@dHIM24 dHIM24 commented May 29, 2026

Copy link
Copy Markdown
Contributor
  • Исправлена высота BaseOption и Option для размеров optionsSize в Select

Чек лист

  • Задача сформулирована и описана в JIRA
  • В названии ветки есть айдишник задачи в JIRA (fix/DS-1234), ссылку прикреплять не надо
  • У реквеста осмысленное название feat(...) или fix(...) по conventional commits (https://www.conventionalcommits.org)
  • Код покрыт тестами и протестирован в различных браузерах
  • Добавленные пропсы добавлены в демки и описаны в документации
  • К реквесту добавлен changeset
const OPTIONS = [
    { key: '1', content: 'Neptunium' },
    { key: '2', content: 'Plutonium' },
    { key: '3', content: 'Americium' },
    { key: '4', content: 'Curium' },
    { key: '5', content: 'Berkelium' },
    { key: '6', content: 'Californium' },
    { key: '7', content: 'Einsteinium' },
    { key: '8', content: 'Fermium' },
];

render(() => {
    return (
        <div style={{ width: 320 }}>
            <SelectDesktop
                allowUnselect={true}
                size={40}
                options={OPTIONS}
                placeholder='Выберите элемент'
                label='Одиночный выбор'
                Option={BaseOption}
                block={true}
            />
        </div>
    );
});

@dHIM24 dHIM24 requested a review from Oladii May 29, 2026 07:17
@changeset-bot

changeset-bot Bot commented May 29, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 344425e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@alfalab/core-components-select Patch
@alfalab/core-components-custom-picker-button Patch
@alfalab/core-components-input-autocomplete Patch
@alfalab/core-components-international-phone-input Patch
@alfalab/core-components-intl-phone-input Patch
@alfalab/core-components-picker-button Patch
@alfalab/core-components Patch
@alfalab/core-components-select-with-tags Patch
@alfalab/core-components-table Patch
@alfalab/core-components-tabs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dHIM24 dHIM24 marked this pull request as draft May 29, 2026 07:20
@coveralls

coveralls commented May 29, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 26806247219

Coverage remained the same at 82.191%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 11638
Covered Lines: 9638
Line Coverage: 82.81%
Relevant Branches: 2209
Covered Branches: 1743
Branch Coverage: 78.9%
Branches in Coverage %: Yes
Coverage Strength: 233.88 hits per line

💛 - Coveralls

@github-actions

Copy link
Copy Markdown
Contributor

Demo build (default)

https://core-ds.github.io/core-components/2232

@github-actions

Copy link
Copy Markdown
Contributor

Demo build (alfasans)

https://core-ds.github.io/core-components/2232-alfasans

@dHIM24 dHIM24 marked this pull request as ready for review May 29, 2026 09:29
@dHIM24 dHIM24 closed this May 29, 2026
@dHIM24 dHIM24 reopened this May 29, 2026
@dHIM24 dHIM24 marked this pull request as draft May 29, 2026 09:30
@dHIM24 dHIM24 marked this pull request as ready for review May 29, 2026 10:47

@fulcanellee fulcanellee May 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

в идеале для подобных тестов нужно размеры пофиксить. например в этом тестируются border radius и нижние радиусы теперь не будут дропать тест. текущий тест кейс не будет честным

@fulcanellee fulcanellee self-requested a review May 29, 2026 12:07
@dHIM24 dHIM24 marked this pull request as draft May 29, 2026 12:48
@dHIM24 dHIM24 marked this pull request as ready for review June 2, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants