Repository navigation
docs(skills): file-reference column URLs and model-aware vector search - #2009
Merged
Merged
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Review complete. No blocking issues — approved ✅; 2 nitpicks below. 🧹 Nitpicks (2) — 🟢 2 low
This PR adds two agent skill docs: the graphile-file-urls skill guide and a pgvector adapter reference for graphile-search, plus an AGENTS.md index row. The new Model-Aware Search section documents
Two low-severity documentation gaps were found: a troubleshooting pointer that dead-ends, and a stamp-filter guarantee stated without its omitted- Reviewed commit: 009e614 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The hand-written skills said nothing about what #2008 shipped. Skills and the
AGENTS.mdskill table only; no code, no generatedcli-*/hooks-*/orm-*skills touched.New skill
graphile-file-urls— how to read a URL for animageoruploadcolumn (scalar or array) on a business-table row:<col>Url(width),<col>Versions, theFileVersiontype, whatwidthpicks, when the result isnull, how it relates todownloadUrl.<source-key>.versions/are signed;.versions/refused in client upload keys; batched per request).fileRefDomains/FILE_REF_DOMAINS.graphile/graphile-presigned-url-plugin/src/file-ref-urls.ts,src/types.ts,src/custom-key.ts,graphile/graphile-storage-registry/src/naming.ts.graphile-search/references/pgvector-adapter.md— new section "Model-Aware Search": the@embeddingModeland@embeddingModelOftags, themodelfilter field, one embedding per model, a failed column sits the search out, rawvectorcallers should passmodel.graphile/graphile-search/src/adapters/pgvector.ts(detectColumns,buildFilterApply),graphile/graphile-search/src/plugin.ts,graphile/graphile-llm/src/embed-inputs.ts,graphile/graphile-llm/src/plugins/text-mutation-plugin.ts.graphile-search/SKILL.md— one pitfall row pointing at that section.AGENTS.md— the new skill in the Tooling Skills table.Audit, no change needed
downloadUrl, versions, or a model name).hooks-storage/orm-storage/cli-storagedescribe the storage API target, not business-table columns, so<col>Urldoes not appear there; nothing to regenerate for this.constructive-starter-kits.zipis the only.zipsibling and that skill is unchanged.Link to Devin session: https://app.devin.ai/sessions/d7ca5693b59842008312a29e09ddacb2
Open in Devin Desktop: https://app.devin.ai/desktop/session/d7ca5693b59842008312a29e09ddacb2?variant=devin
Requested by: @pyramation
🟢 Devin Review found nothing to fix · View findings