Repository navigation
docs(skills): sync hand-written skills with main; drop duplicate skills and stale zip - #2010
pyramation wants to merge 1 commit into
Conversation
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Review complete. No issues found — approved ✅. This PR touches only
Every documented field name, input shape, CLI flag, and harness API referenced by the changed docs was checked against the corresponding source (graphile-search plugin, pgpm CLI, pgsql-test) and found accurate; no stale references to the removed skills or old field names remain. No code changes are involved, so the merge risk is minimal. Reviewed commit: bcbdc64 |
Summary
Skills/docs only (no product code, no generated files). Applies the constructive part of the cross-repo skills audit (§2, §2.4, §4, §5) after re-verifying every statement against current
main.Per-skill changes and what each was verified against
pgpm— fixes a wrong statement.references/cli.md(Admin Users): the example createdplatform_servicewith--bypassrlsand said platform components use such a login. Platform logins areNOBYPASSRLS. Example now uses a genericmigratorlogin, states the platform login isNOBYPASSRLSand must not get--bypassrls, and that--bypassrlscannot be combined with--test.constructive-db/ci/rules.json(R11),constructive-db/docs/architecture/platform-access-rules.md(R11),constructive-db/docs/architecture/role-exposure-boundary.md,constructive-db/application/app/__tests__/request-database.provision.test.ts(rolbypassrlsfalse),graphql/server/README.md,pgpm/cli/src/commands/admin-users/add.ts.SKILL.mdreferences table: one row pointingpgpm diff/import/transformat the existingpgpm-projectionsskill (it already documentspgpm diffin depth; no duplicate prose). Verified:pgpm/cli/src/commands/diff.ts.graphile-search— fixes wrong names/inputs, adds BM25 filter semantics.references/codegen-sdk-queries.md,SKILL.md: score/orderBy names were wrong —bm25ContentScore/BM25_CONTENT_SCORE_*→contentBm25Score/CONTENT_BM25_SCORE_*;embeddingDistance/EMBEDDING_DISTANCE_*→embeddingVectorDistance/EMBEDDING_VECTOR_DISTANCE_*(and the naming-pattern bullets). The rest of the skill already used the correct names.graphile/graphile-search/src/plugin.ts(pgSearchScore,pgSearchOrderByEnuminflectors),src/__tests__/bm25-match-count.test.ts,src/__tests__/orderby-variable.test.ts.SKILL.md,references/bm25-adapter.md,references/pgvector-adapter.md: filter input shapes were wrong — BM25 is{ query, threshold }(noindexNameinput); pgvector isVectorNearbyInput { vector, model, metric, distance, includeChunks }(notVectorSearchInput { query, metric }).graphile/graphile-search/src/adapters/bm25.ts,src/adapters/pgvector.ts.references/bm25-adapter.md: new "Filter Semantics" — withoutthresholdonly matching rows (score < 0) are returned sototalCountmatches;thresholdis inclusive (<=); BM25 orderBy requires the filter (error names it), also for variableorderBy.src/adapters/bm25.ts(matchClause),src/plugin.ts(orderBy validation),src/__tests__/bm25-match-count.test.ts,src/__tests__/orderby-variable.test.ts.constructive-testing— adds missing coverage.references/pgsql-test-transactions.md: new "Deferred Constraints Under Rollback Isolation" (db.deferredConstraints/DB_DEFERRED_CONSTRAINTS:off|check|immediate,db.checkConstraints(), what no mode covers).SKILL.mdtable row updated.postgres/pgsql-test/src/test-client.ts(beforeEach,afterEach,checkConstraints,publish),postgres/pgsql-test/src/connect.ts,postgres/pgsql-test/README.md.Removed duplicates (canonical home: constructive-io/constructive-skills)
Deleted
.agents/skills/constructive-principals/and.agents/skills/constructive-plan-cascade-sdk/.git grepfound no references to either in this repo (AGENTS.md tables, other skills, docs), so there was nothing to repoint; the canonical copies areconstructive-skills/.agents/skills/constructive-principalsandconstructive-skills/.agents/skills/constructive-billing.Content in the deleted copies not present in constructive-skills
main(checked by greppingconstructive-skills/.agents/skills; listed so it can be merged there, not re-verified here):constructive-principals/references/principal-fields.md(whole file): field reference for theprincipalstable, theprincipal_entitiesjunction table, and thecreate_principal/delete_principalmutations.constructive-principals/SKILL.md: error codesPRINCIPAL_NOT_FOUND,NOT_OWNER;csdk ... create-principalCLI example; React hooksuseCreatePrincipalMutation,usePrincipalsQuery;principal_entitiesmentions.constructive-plan-cascade-sdk/SKILL.md: "Four Access-Control Layers" overview; 5-step plan configuration workflow; changing plans section; reading feature flags from the SDK; app-level defaults without plans (limit/cap/meter defaults); SDK table reference. Table names used there that constructive-skills does not mention:appPlanCap,appPlanMeterLimit,appMeterDefault,appPlanLimit,appPlanPricing,appPlanSubscription,appPlanOverride,defaultPlanLimit,resolve_cap. I did not verify these names against currentmain, so check them before carrying them over.Removed stale zip
Deleted
.agents/skills/constructive-starter-kits.zip(its folder had changed after the zip was built). No consumer found:git grepfor\.zip,constructive-starter-kits.zip,skills/*.zipacross source,.github/workflows/*, allpackage.json,.gitignore/.npmignore. Only hits are unrelated test/report artifacts..zip,agents/skills,constructive-starter-kits. Only hits are Playwright artifacts (test-results-core.zip,*-report.zip).constructive-skills/AGENTS.md: skill.zippackages are not committed.Audit items rejected or not verified
cli-*,hooks-*,orm-*) stale: the audit's guess.cli-auth/hooks-auth/orm-authwere last regenerated 2026-11-05 andsdk/changed after that (2026-11-16), so they may be stale. Not hand-edited; they need a regeneration run.pgpm diffmissing from thepgpmskill: partly wrong.pgpm-projectionsalready covers it, so I only added a pointer.--ledger/--emit-ledger(backfilling an existing database's ledger) are left out because the platform is greenfield-only.Link to Devin session: https://app.devin.ai/sessions/8676620977654283a6a1db21557951ae
Open in Devin Desktop: https://app.devin.ai/desktop/session/8676620977654283a6a1db21557951ae?variant=devin
Requested by: @pyramation
🟢 Devin Review found nothing to fix · View findings