Skip to content

🤖 refactor: align sub-project creation scope #3266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ammario merged 6 commits into from
May 12, 2026
Merged

🤖 refactor: align sub-project creation scope #3266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8d0908a
Refine sub-project creation scope handling
ammar-agent May 10, 2026
92e8093
Trim sub-project scope helpers
ammar-agent May 10, 2026
897f0dc
Drain sub-project scope cleanup
ammar-agent May 10, 2026
28b1286
Align new workspace shortcut with sub-project target
ammar-agent May 10, 2026
66fa1ed
Use live metadata for new workspace shortcut
ammar-agent May 10, 2026
728cb85
Require live project for secrets target
ammar-agent May 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/browser/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ import {
} from "@/constants/layout";
import { buildCoreSources, type BuildSourcesParams } from "./utils/commands/sources";

import { getTopLevelProjectEntries } from "@/common/utils/subProjects";
import { THINKING_LEVELS, type ThinkingLevel } from "@/common/types/thinking";
import { CUSTOM_EVENTS } from "@/common/constants/events";
import { isWorkspaceForkSwitchEvent } from "./utils/workspaceEvents";
Expand Down Expand Up @@ -1237,7 +1238,7 @@ function AppInner() {
<MultiProjectWorkspaceCreateModal
isOpen={isMultiProjectWorkspaceModalOpen}
onClose={() => setMultiProjectWorkspaceModalOpen(false)}
projectOptions={Array.from(userProjects.keys()).map((projectPath) => ({
projectOptions={getTopLevelProjectEntries(userProjects).map(([projectPath]) => ({
projectPath,
projectName:
projectPath.split("/").pop() ?? projectPath.split("\\").pop() ?? "Unnamed Project",
Expand Down
85 changes: 0 additions & 85 deletions src/browser/components/DraggableSection/DraggableSection.tsx
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions src/browser/components/ProjectSidebar/ProjectSidebar.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ import * as PopoverErrorModule from "../PopoverError/PopoverError";
import * as SectionHeaderModule from "../SectionHeader/SectionHeader";
import * as WorkspaceSectionDropZoneModule from "../WorkspaceSectionDropZone/WorkspaceSectionDropZone";
import * as WorkspaceDragLayerModule from "../WorkspaceDragLayer/WorkspaceDragLayer";
import * as SectionDragLayerModule from "../SectionDragLayer/SectionDragLayer";
import * as DraggableSectionModule from "../DraggableSection/DraggableSection";
import { updatePersistedState } from "@/browser/hooks/usePersistedState";
import type ProjectSidebarComponent from "./ProjectSidebar";
import type * as WorkspaceStatusIndicatorModuleExports from "../WorkspaceStatusIndicator/WorkspaceStatusIndicator";
Expand Down Expand Up @@ -521,12 +519,6 @@ function installProjectSidebarTestDoubles() {
spyOn(WorkspaceDragLayerModule, "WorkspaceDragLayer").mockImplementation(
(() => null) as unknown as typeof WorkspaceDragLayerModule.WorkspaceDragLayer
);
spyOn(SectionDragLayerModule, "SectionDragLayer").mockImplementation(
(() => null) as unknown as typeof SectionDragLayerModule.SectionDragLayer
);
spyOn(DraggableSectionModule, "DraggableSection").mockImplementation(
TestWrapper as unknown as typeof DraggableSectionModule.DraggableSection
);
void mock.module("../PositionedMenu/PositionedMenu", () => ({
PositionedMenu: (props: { open: boolean; children: React.ReactNode }) =>
props.open ? <div data-testid="project-actions-menu">{props.children}</div> : null,
Expand Down
Loading
Loading