🤖 refactor: align sub-project creation scope#3266
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review Final pass after three adversarial code-quality critique rounds. The follow-up commits only reduce indirection and redundant code while preserving the PR behavior. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 897f0dcd8a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Addressed the shortcut parity finding: Ctrl+N now uses the selected workspace metadata subProjectPath just like the command palette action. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 28b128625d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Addressed the live-metadata follow-up: Ctrl+N now derives the sub-project from the current sidebar metadata rather than the imperative store. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 66fa1eddf8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Addressed the SecretsSection stale-path regression by requiring the project config to exist before accepting a project-scoped secrets target. |
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
Audit and prune sub-project-specific divergence so creation, defaults, command actions, and backend APIs use the same parent-owned workspace model. Sub-projects remain as UI/cwd sections, while shared workspace settings and top-level project actions now consistently resolve to the parent project.
Background
Sub-project workspaces share the parent checkout and store the child context in
subProjectPath. Several entry points had grown bespoke handling that either dropped the child context, treated children as standalone top-level projects, or exposed unsupported sub-project behavior.Implementation
assignWorkspaceToSubProjectso backend callers can pass either the parent or current sub-project path.Validation
bun test src/common/utils/subProjects.test.ts src/browser/hooks/useStartWorkspaceCreation.test.ts src/browser/utils/commands/sources.test.ts src/browser/contexts/ProjectContext.test.tsx src/node/services/projectService.test.tsmake typecheckmake lintmake static-checkRisks
Moderate: this touches shared project routing and creation scope logic. The intended behavior change is to stop treating sub-projects as standalone owners outside the narrow UI/cwd cases. Parent-level project pickers now hide sub-projects where the backend/runtime only supports parent project semantics.
Generated with
mux• Model:openai:gpt-5.5• Thinking:high• Cost:$unknown