feat(argocd): emit deployment value sources in generated values - #2373
Merged
Conversation
Contributor
|
🤖 Hey ! The security scan report for the current pull request is available here. |
KepoParis
force-pushed
the
feat/deployment-value-sources-api
branch
from
July 27, 2026 15:36
c8fbc42 to
ad4ebf3
Compare
KepoParis
force-pushed
the
feat/deployment-value-sources-argocd
branch
from
July 27, 2026 15:38
3f38536 to
e30282e
Compare
Contributor
|
🤖 Hey ! The security scan report for the current pull request is available here. |
13 tasks
StephaneTrebel
previously approved these changes
Jul 28, 2026
KepoParis
force-pushed
the
feat/deployment-value-sources-api
branch
from
July 28, 2026 15:05
ad4ebf3 to
13f0fc0
Compare
KepoParis
force-pushed
the
feat/deployment-value-sources-argocd
branch
from
July 28, 2026 15:14
e30282e to
1d87078
Compare
KepoParis
force-pushed
the
feat/deployment-value-sources-api
branch
from
July 28, 2026 16:07
13f0fc0 to
b712f61
Compare
KepoParis
force-pushed
the
feat/deployment-value-sources-argocd
branch
from
July 28, 2026 16:10
1d87078 to
f4c23a4
Compare
KepoParis
force-pushed
the
feat/deployment-value-sources-api
branch
from
July 28, 2026 19:37
b712f61 to
29f69d8
Compare
KepoParis
force-pushed
the
feat/deployment-value-sources-argocd
branch
from
July 28, 2026 19:37
f4c23a4 to
bd958a3
Compare
Contributor
|
🤖 Hey ! The security scan report for the current pull request is available here. |
KepoParis
force-pushed
the
feat/deployment-value-sources-api
branch
from
July 29, 2026 15:33
29f69d8 to
99af2a8
Compare
KepoParis
force-pushed
the
feat/deployment-value-sources-argocd
branch
from
July 29, 2026 15:34
bd958a3 to
d38697d
Compare
KepoParis
force-pushed
the
feat/deployment-value-sources-argocd
branch
from
July 29, 2026 16:19
d38697d to
e45f052
Compare
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
shikanime
approved these changes
Jul 29, 2026
iliesmrf
approved these changes
Jul 29, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 29, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues liées
Issues numéro: #2247
Note
PR empilée (stacked) sur #2372. À rebaser au fur et à mesure que la pile est mergée.
Quel est le comportement actuel ?
Les sources de valeurs (value sources) persistées via l'API (#2372) ne sont
pas propagées dans les valeurs générées pour ArgoCD : le chart
dso-envnereçoit donc aucune valeur externe.
Quel est le nouveau comportement ?
valueSources(triées parorder, avec l'internalRepoNamedu dépôt) dans les
selectdes requêtes argocd et project.ValueSourceau schéma de valeurs et mapping de chaquesource dans les
repositoriesde l'application : les sources externesrésolvent un
repoURL, unrefet unetargetRevision; les sourcesinternes ne portent que leur
path.valueSources: []pour les valeurs dérivées des dépôts(hors déploiement).
Cette PR introduit-elle un breaking change ?
Non. En l'absence de value sources,
valueSourcesvaut[]; les valeursgénérées restent inchangées pour les déploiements existants.
Autres informations
Partie GitOps/ArgoCD de l'adaptation au nouveau helm-chart
(https://github.com/cloud-pi-native/helm-charts) permettant d'ajouter des
valeurs externes au chart
dso-env. Les composants client suivront dans unePR distincte.