feat(client): add deployment value sources editor - #2374
Merged
Conversation
13 tasks
Contributor
|
🤖 Hey ! The security scan report for the current pull request is available here. |
StephaneTrebel
requested review from
a team and
StephaneTrebel
and removed request for
StephaneTrebel
July 28, 2026 06:52
StephaneTrebel
requested changes
Jul 28, 2026
StephaneTrebel
left a comment
StephaneTrebel
left a comment
Collaborator
There was a problem hiding this comment.
Et ils sont où, les tests Playwright qui serrent les boulons sur tout ça, hmm ? 😁
KepoParis
force-pushed
the
feat/deployment-value-sources-argocd
branch
2 times, most recently
from
July 28, 2026 16:10
1d87078 to
f4c23a4
Compare
KepoParis
force-pushed
the
feat/deployment-value-sources-client
branch
from
July 28, 2026 16:36
b1dc51b to
38e9a77
Compare
KepoParis
force-pushed
the
feat/deployment-value-sources-argocd
branch
from
July 28, 2026 19:37
f4c23a4 to
bd958a3
Compare
KepoParis
force-pushed
the
feat/deployment-value-sources-client
branch
from
July 28, 2026 19:38
38e9a77 to
e687a21
Compare
Contributor
|
🤖 Hey ! The security scan report for the current pull request is available here. |
StephaneTrebel
previously approved these changes
Jul 29, 2026
StephaneTrebel
left a comment
StephaneTrebel
left a comment
Collaborator
There was a problem hiding this comment.
C'est vachement mieux qu'avant dis-donc, bien joué 👍
KepoParis
force-pushed
the
feat/deployment-value-sources-argocd
branch
from
July 29, 2026 15:34
bd958a3 to
d38697d
Compare
KepoParis
force-pushed
the
feat/deployment-value-sources-client
branch
from
July 29, 2026 15:35
e687a21 to
8d22e75
Compare
KepoParis
force-pushed
the
feat/deployment-value-sources-argocd
branch
from
July 29, 2026 16:19
d38697d to
e45f052
Compare
KepoParis
force-pushed
the
feat/deployment-value-sources-client
branch
from
July 29, 2026 16:19
8d22e75 to
feeff64
Compare
KepoParis
force-pushed
the
feat/deployment-value-sources-client
branch
from
July 29, 2026 17:21
feeff64 to
37aeb5d
Compare
iliesmrf
approved these changes
Jul 29, 2026
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues liées
Issues numéro: #2247
Note
PR empilée (stacked) sur #2373. À rebaser au fur et à mesure que la pile est mergée.
Quel est le comportement actuel ?
La modale de déploiement ne propose qu'un champ texte libre « Fichiers values
(Helm) » et ne permet pas de gérer des sources de valeurs (value sources)
internes / externes exploitées par le backend (#2372, #2373).
Quel est le nouveau comportement ?
DeploymentValueSourcesetDeploymentValueSourceOptionpour gérer une liste ordonnée de sources devaleurs (internes / externes), en remplacement du champ texte libre des
fichiers values Helm dans
DeploymentRepoOption.source externe ; les nouvelles sources de déploiement ont
valueSources: []par défaut.
UpdateDeploymentSchema(au lieu deCreateDeploymentSchema) lorsqu'un id de déploiement est présent, etfactorisation de la gestion des requêtes create / update dans
DeploymentModal.toStringValuepour convertir les valeurs des inputs DSFRen chaînes.
Cette PR introduit-elle un breaking change ?
Non. Changement d'interface uniquement ; les déploiements existants restent
compatibles.
Autres informations
Partie client de l'adaptation au nouveau helm-chart
(https://github.com/cloud-pi-native/helm-charts) permettant d'ajouter des
valeurs externes au chart
dso-env. Dernière PR de la pile.