feat(joint-core): allow mvc.View to override the joint- class-name prefix#3310
Merged
Geliogabalus merged 1 commit intoMay 13, 2026
Merged
Conversation
…efix Adds an opt-in `classNamePrefix` property on `mvc.View` (defaults to `config.classNamePrefix`) and threads it through `util.addClassNamePrefix` and `util.removeClassNamePrefix` via an optional second argument. Setting `classNamePrefix: ''` lets a subclass opt out of prefixing entirely; the theme class still uses the global `joint-` prefix. Includes QUnit coverage for the new util argument and for the View override behavior (default, custom, empty, multi-name, idempotency, SVG, theme independence). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
Geliogabalus
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
classNamePrefixproperty onmvc.View(defaults toconfig.classNamePrefix); set to''to opt out of prefixing or to a custom string to replace it.util.addClassNamePrefix/util.removeClassNamePrefixaccept an optional prefix argument; falsey prefix is a no-op.joint-prefix, independent of the view'sclassNamePrefix.Test plan
util.addClassNamePrefix(custom prefix, multi-name, empty/null no-op, idempotency)util.removeClassNamePrefix(custom prefix, multi-name, empty/null no-op, cross-prefix isolation)mvc.ViewclassNamePrefixoverride (default, custom, empty opt-out, multi-name, idempotency, SVG element, theme independence)yarn grunt karma:joint— 1969/1969 pass🤖 Generated with Claude Code