feat(joint-core, joint-react): mvc.View classNamePrefix override + Paper adoption#3311
Merged
Geliogabalus merged 2 commits intoMay 13, 2026
Merged
Conversation
…efix Adds an opt-in `classNamePrefix` property on `mvc.View` (defaults to `config.classNamePrefix`) and threads it through `util.addClassNamePrefix` and `util.removeClassNamePrefix` via an optional second argument. Setting `classNamePrefix: ''` lets a subclass opt out of prefixing entirely; the theme class still uses the global `joint-` prefix. Includes QUnit coverage for the new util argument and for the View override behavior (default, custom, empty, multi-name, idempotency, SVG, theme independence). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…efix on Paper Replaces the custom `_ensureElClassName` override with the new `classNamePrefix: ''` mechanism from `mvc.View`. Sets `className` to `'jj-paper joint-paper'` directly so both classes land on the root element without the global `joint-` prefix. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Geliogabalus
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
joint-core: newclassNamePrefixproperty onmvc.View(defaults toconfig.classNamePrefix); set''to opt out, or a custom string to replace the prefix.util.addClassNamePrefix/util.removeClassNamePrefixaccept an optional prefix arg.joint-react:Paperpreset usesclassNamePrefix: ''+className: 'jj-paper joint-paper'instead of overriding_ensureElClassName.Companion PR against
master(core-only, no react): #3310.Test plan
mvc.Viewoverride (default / custom / empty / multi-name / idempotent / SVG / theme independence)yarn grunt karma:joint— 1969/1969 passjj-paper joint-paperon the root, nojoint-double-prefix🤖 Generated with Claude Code