feat: add Super Launch footer badge - #81
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original request
Add the supplied Super Launch badge to xpenser using the PR workflow, without creating a blog post. The badge should link to
https://www.superlaun.ch/products/2933and use the hostedhttps://www.superlaun.ch/badge.pngasset.What changed
rel="noopener".Reasoning
The supplied snippet declared a 300×300 image, but the hosted PNG is actually 470×130. Using the verified intrinsic dimensions prevents distortion, while a 235px rendered width matches the scale of the existing footer badges. The implementation follows the repository's established plain
<img>convention for small third-party hosted badges, avoiding a new Next.js remote-image allowlist entry for a single footer asset.Blog post
Skipped per the original request. This is a small badge-only footer attribution and does not justify a standalone public release post.
Screenshots / preview evidence
Preview: https://xpenser-pr-081.cleverbrush.com
Manual QA exercised the footer at 390×844 and 1440×900 in light and dark themes, with mobile and desktop screenshots captured during the session. Verified:
target="_blank",rel="noopener", alt text, and lazy-loading attribute are present.https://www.superlaun.ch/products/2933in a separate tab.The passing Playwright e2e job and its Playwright report artifact provide stable browser-test evidence for the updated public homepage flow.
Validation
Local
npm run lintnpm run typechecknpm test— 95 files, 520 tests passedGitHub / preview
http.server.duration.countchecked; recorded as an infrastructure telemetry skip becausexpenser-web-pr-81did not appear after an ingestion recheck127.0.0.1:8787was unavailableTelemetry
For
xpenser-web-pr-81in the post-QA one-hour window:http.server.duration.countreturned no matching metric series before or after the ingestion wait.Notification
The notification token is configured, but the default PR-ready notifier at
http://127.0.0.1:8787/v1/pr-readyrefused the connection. Notification was therefore skipped without exposing credentials.