Skip to content

Revert "feat: add Super Launch footer badge" - #84

Merged
andrewzolotukhin merged 2 commits into
mainfrom
revert-81-feat/super-launch-footer-badge
Jul 26, 2026
Merged

Revert "feat: add Super Launch footer badge"#84
andrewzolotukhin merged 2 commits into
mainfrom
revert-81-feat/super-launch-footer-badge

Conversation

@andrewzolotukhin

@andrewzolotukhin andrewzolotukhin commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Original request

Reverts #81 (feat: add Super Launch footer badge).

What changed

  • Keeps the generated revert unchanged.
  • Stabilizes the existing Playwright navigation checks by waiting for each destination URL and using a focused 15-second assertion timeout for the destination UI.
  • Covers Dashboard → Transactions → Add → Preferences and category trend drilldown without fixed sleeps, reclicks, or global retries.

Why the check failed

The refreshed preview occasionally needed longer than Playwright's default 5-second assertion timeout to finish a client-side navigation and load its route chunk. The trace showed successful Next.js RSC responses, and retries/live navigation succeeded. This was unrelated to the footer-badge revert.

Validation

  • npm run lint
  • npm run typecheck
  • npm test — 95 files, 520 tests
  • Focused preview Playwright run with --repeat-each=2 — 7/7 passed
  • GitHub Lint and test
  • GitHub Deploy PR environment
  • GitHub Playwright e2e
  • Refreshed preview QA at https://xpenser-pr-084.cleverbrush.com
    • Super Launch footer link absent
    • Dashboard → Transactions → Add → Preferences verified
    • Category drilldown covered by the green full Playwright workflow

Screenshots

No screenshot attached: this revert removes an existing footer badge and introduces no replacement UI. The refreshed preview footer was visually checked after deployment.

Observability

SigNoz was queried for error spans and total spans over the last hour for xpenser-web-pr-84 and xpenser-api-pr-84. Neither service emitted trace data in that window, so telemetry validation is unavailable rather than conclusively clean.

Blog

Skipped; this revert does not require a product announcement.

@andrewzolotukhin
andrewzolotukhin temporarily deployed to pr-84 July 26, 2026 18:30 — with GitHub Actions Inactive
@andrewzolotukhin
andrewzolotukhin temporarily deployed to pr-84 July 26, 2026 19:04 — with GitHub Actions Inactive
@andrewzolotukhin
andrewzolotukhin merged commit f69d209 into main Jul 26, 2026
4 checks passed
@andrewzolotukhin
andrewzolotukhin deleted the revert-81-feat/super-launch-footer-badge branch July 26, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant