Revert "feat: add Super Launch footer badge" - #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original request
Reverts #81 (
feat: add Super Launch footer badge).What changed
Why the check failed
The refreshed preview occasionally needed longer than Playwright's default 5-second assertion timeout to finish a client-side navigation and load its route chunk. The trace showed successful Next.js RSC responses, and retries/live navigation succeeded. This was unrelated to the footer-badge revert.
Validation
npm run lintnpm run typechecknpm test— 95 files, 520 tests--repeat-each=2— 7/7 passedLint and testDeploy PR environmentPlaywright e2eScreenshots
No screenshot attached: this revert removes an existing footer badge and introduces no replacement UI. The refreshed preview footer was visually checked after deployment.
Observability
SigNoz was queried for error spans and total spans over the last hour for
xpenser-web-pr-84andxpenser-api-pr-84. Neither service emitted trace data in that window, so telemetry validation is unavailable rather than conclusively clean.Blog
Skipped; this revert does not require a product announcement.