Auto-discover ignored users from silent escalation policies#276
Merged
Conversation
Replace manual ignoredusers config with auto-discovery: classify escalation policies as REAL (has schedule_reference) or SILENT (user_reference only), then extract bot user IDs from SILENT policies. Backward compatible — manual ignoredusers still works with deprecation warning. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
==========================================
+ Coverage 67.36% 67.56% +0.19%
==========================================
Files 34 34
Lines 5169 5210 +41
==========================================
+ Hits 3482 3520 +38
- Misses 1468 1470 +2
- Partials 219 220 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
3 tasks
Mhodesty
pushed a commit
to Mhodesty/srepd
that referenced
this pull request
Jun 8, 2026
Follow-up to clcollins#276: now that ignored users are auto-discovered from silent escalation policies, remove ignoredusers from the example config generated by --create and from the optional keys help text. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #269
ClassifyEscalationPolicy()— classifies policies as REAL (hasschedule_referencetargets) or SILENT (onlyuser_referencetargets)ExtractSilentPolicyUsers()— extracts deduplicated bot user IDs from all SILENT policiesNewConfigWithClient: whenignoredusersis absent, auto-discovers from silent policies; when present, uses manual list with deprecation warningignoredusersto the deprecation registryEscalationPolicyResponsesfor testing policies with escalation rulesTest plan
make test-allpasses (fmt, vet, lint, test, race)ignoredusersfrom config → auto-discovery produces same incident listignoredusers→ deprecation warning logged, still works🤖 Generated with Claude Code