Remove ignoredusers from config template and help text#277
Merged
Conversation
Follow-up to #276: now that ignored users are auto-discovered from silent escalation policies, remove ignoredusers from the example config generated by --create and from the optional keys help text. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
=======================================
Coverage 67.56% 67.56%
=======================================
Files 34 34
Lines 5210 5210
=======================================
Hits 3520 3520
Misses 1470 1470
Partials 220 220 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #276. Now that ignored users are auto-discovered from silent escalation policies, remove
ignoredusersfrom:config --createoptionalKeyshelp map used byconfig --validateThe
ignoreduserskey is still accepted at runtime (backward compatible via the deprecation path in #276), but new configs will no longer include it.Test plan
go test ./...passesconfig --createno longer includesignoredusersin generated configconfig --validateno longer listsignoredusersas an optional key🤖 Generated with Claude Code