test: Re-implement the coco_runner test fixture#282
Merged
Conversation
ketiltrout
force-pushed
the
coco_runner
branch
3 times, most recently
from
1dd4acc to
1ee846b
Compare
This isn't complete, but it is able to run cocod in a more robust way than the simplistic `cocod` fixture I had created before. Features: * uses `fakeredis` to spin up a test redis server on demand * also performs the function of the old `rest_farm` fixture via the `add_targets` method. * Client support not yet present. I have created a test that tests the fixture just as a minimal functionality test.
ljgray
approved these changes
Jun 9, 2026
ketiltrout
added a commit
that referenced
this pull request
Jun 10, 2026
ketiltrout
added a commit
that referenced
this pull request
Jun 10, 2026
The comet registration via the manager is now deferred until after the early exit caused by --check-config. This fixes a problem where using --check-config would result in `cocod` spuriously registering its start with comet, even though it was only doing a test run-through of the config. The prior comet test has been migrated from the `cocod` fixture to the `coco_runner` and the `mock_comet` fixture no longer automatically integrates with the `cocod` fixture. This is the problem I alluded to in #277 Requires #282.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't complete, but it is able to run cocod in a more robust way than the simplistic
cocodfixture I had created before.Features:
fakeredisto spin up a test redis server on demandrest_farmfixture via theadd_targetsmethod.I have created a test that tests the fixture just as a minimal functionality test.