fix(core): Don't register with comet if --check-config is used#283
Merged
Conversation
ketiltrout
force-pushed
the
fix_comet_config_check
branch
2 times, most recently
from
66c027f to
02e4965
Compare
ketiltrout
force-pushed
the
fix_comet_config_check
branch
from
02e4965 to
8140279
Compare
ketiltrout
force-pushed
the
coco_runner
branch
2 times, most recently
from
1dd4acc to
1ee846b
Compare
ketiltrout
force-pushed
the
fix_comet_config_check
branch
from
8140279 to
fd2f028
Compare
ketiltrout
force-pushed
the
coco_runner
branch
2 times, most recently
from
073a49b to
531387d
Compare
ljgray
approved these changes
Jun 9, 2026
ketiltrout
force-pushed
the
fix_comet_config_check
branch
from
fd2f028 to
e797284
Compare
The comet registration via the comet manager is now deferred until after the early exit caused by --check-config. This fixes a problem where using --check-config would result in `cocod` spuriously registerring its start with comet, even though it was only doing a test run-through of the config. The prior comet test has been migrated from the `cocod` fixture to the `coco_runner` and the `mock_comet` fixture no longer automatically integrates with `cocod`. This is the problem I alluded to in #277
ketiltrout
force-pushed
the
fix_comet_config_check
branch
from
e797284 to
824a0a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comet registration via the manager is now deferred until after the early exit caused by --check-config.
This fixes a problem where using --check-config would result in
cocodspuriously registering its start with comet, even though it was only doing a test run-through of the config.The prior comet test has been migrated from the
cocodfixture to thecoco_runnerand themock_cometfixture no longer automatically integrates with thecocodfixture.This is the problem I alluded to in #277
Requires #282.