Conversation
jaymzh
approved these changes
Sep 26, 2026
CI stub: - Read the version passed to SBOM/BlackDuck from the VERSION file instead of a hardcoded 3.1.3. The shared workflow's file detection is a placeholder that never reads the file, so the stub reads it itself. - Blank the Go build/clean commands left over from another project - Replace the deprecated ::set-output workflow command with $GITHUB_OUTPUT Copilot instructions: - Name the workflow files that actually exist - Drop the >80% coverage requirement; no coverage tool is configured - Drop the cucumber instructions; the suite cannot run - Drop the Skip Habitat and Skip Omnibus labels, which Expeditor does not define here - Replace "License compliance checks" (license_scout is disabled) with the scans the pipeline actually runs Signed-off-by: Tim Smith <tsmith84@proton.me>
tas50
force-pushed
the
fix-ci-stub-and-copilot-docs
branch
from
September 28, 2026 02:03
4608157 to
383350c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI stub (
ci-main-pull-request-stub-1.0.7.yml)'3.1.3'while the gem is at 3.1.10. The shared workflow'sdetect-version-source-type: filelooks like the fix, but itsset-application-versionjob is a placeholder that only echoes its inputs and never reads the file. Instead, thedetect-custom-metadatajob now readsVERSION, which Expeditor bumps on every merge, and passes it to theversioninput.polaris-coverity-build-command: 'go build -o bin/chef-cli.exe'and'go clean'were left over from another project. They are blanked, along with the commented-out Go equivalents. Polaris is disabled, so this doesn't change current behaviour, but it stops them running if Polaris is ever turned on.::set-output— switched to writing$GITHUB_OUTPUT..github/copilot-instructions.mdCorrected statements that aren't true of this repo:
ci-main-pull-request-checks.yml, which doesn't exist. It now lists the real workflow files and what each one runs.bundle exec cucumber, which fails: cucumber isn't in the bundle. The test step is nowbundle exec rake, which runs style and spec.Expeditor: Skip Habitat/Skip Omnibuslabels, which.expeditor/config.ymldoesn't define.license_scoutisfalse. That line is replaced with the scans the pipeline actually runs.Added
allchecksandRovoto the cspell word list, since this PR edits the file that contains them.Testing