Conversation
Collaborator
|
Buildkite is formally deprecated at Progress. Theoretically they're not going to move to Drone, but I think this is clearly the "right thing" at least for now. Go ahead and kill the BK in this PR and then @tpowell-progress can nuke the BK requirment when he merges this. |
- Add a GitHub Actions unit workflow that runs the specs on Ruby 3.1, 3.2, 3.3, 3.4 and 4.0 on Linux, Windows and macOS. Buildkite only covers 3.1 and 3.4, and there is no Buildkite Windows image for 3.2 or 4.0. - Port the four Cucumber scenarios to RSpec and remove features/. Cucumber was not in the bundle and nothing ran it, so these tests had not run in years. The ported file-loading scenario is the only spec that reads a real config file from disk. - Stop registering the Bundler gem tasks twice in the Rakefile, which made build and release run their actions twice. Signed-off-by: Tim Smith <tsmith84@proton.me>
tas50
force-pushed
the
ci-run-all-tests
branch
from
September 28, 2026 02:03
e8162b8 to
86aff7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Before this change, CI skipped part of the test suite:
New
unitworkflow.github/workflows/unit.ymlrunsrake specon a matrix of Ruby 3.1-4.0 ×ubuntu-latest,windows-latestandmacos-latest, usingruby/setup-rubywith bundler caching. Chef's Buildkite setup has no Windows image for Ruby 3.2 or 4.0 (rubydistros/windows-2019publishes only 3.1, 3.3 and 3.4), so GitHub Actions is the only way to cover them.BUNDLE_WITHOUT: debug:docsskips pry/byebug and yard, which the specs don't need.The Buildkite pipeline is unchanged. Its check is probably required by branch protection. Once this workflow has proven itself, maintainers may want to retire it.
Cucumber → RSpec
features/had four scenarios. None of them had run in years: cucumber isn't in the Gemfile or gemspec, no rake task or CI job called it, and one step definition file was empty. The scenarios are ported tospec/mixlib/config_usage_spec.rb, andfeatures/is removed. The file-loading scenario is now the only spec that reads a real config file from disk (spec/fixtures/sample_config.rb). Every otherfrom_filespec stubs the read.Rakefile
Both
require "bundler/gem_tasks"andBundler::GemHelper.install_taskswere present, sobuildandreleaseeach ran their actions twice (Rake::Task["build"].actions.sizewas 2). The duplicate is removed. This PR also fixes the "uploaeded" typo, because spellcheck flags any file a PR touches. #143 makes the identical fix.Not changed: minimum Ruby
required_ruby_versionstays at>= 3.1. Ruby 3.1 is EOL, but Chef Infra Client 18 ships it, and raising the floor would cut Chef 18 off from future mixlib-config releases. The matrix now tests that floor alongside every newer Ruby.Merge notes
This PR and #144 both edit
.github/copilot-instructions.mdin the directory-tree section, so whichever merges second will need a small rebase. The added cspell entry (Rovo) is identical in both PRs.Testing
bundle exec rake specpasses locally on Ruby 4.0.7 (160 examples). cookstyle, actionlint and cspell are clean.