Keep missing Cargo test binaries non-fatal - #716
Merged
Conversation
This was referenced Aug 17, 2026
This was referenced Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assert_cmdfallback incodex-utils-cargo-binCargoBinError::NotFoundwhen a cross-package binary is absentassert_cmddependency and refresh convergence metadataWhy
Focused core/app-server runs do not always receive cross-package
CARGO_BIN_EXE_*variables. Optional callers used.ok()/if let Ok(...), but the helper panicked internally before those fallbacks could run. This masked 14 #707-aligned filters before their product assertions.Validation
just test -p codex-utils-cargo-bin: 2/2 passedbazel test //codex-rs/utils/cargo-bin:all --test_output=errors: Cargo and unit tests passed; Windows cross test skipped on macOSCARGO_BIN_EXE_*errors (25 cases: 9 passed, 16 exposed real Restore MultiAgentV2 child configuration and lifecycle contracts #707 failures)just argument-comment-lint: 902 targets passedjust bazel-lock-updateandjust bazel-lock-checkjust fix -p codex-utils-cargo-binjust fmtgit diff --check7034270582cd028e0145eff999afc42e337798dd: 473 guarded paths, 0 violations, 6 snapshots reproducedproject_open_blocked; verdict remains UNKNOWNScope
This PR only restores the helper's non-panicking
Resultcontract. The newly visible MultiAgentV2 assertions remain assigned to #707. The original #706 SDK timeout, proxy, FIFO, and guardian clusters remain separate follow-up stages.Refs #706
Refs #707