Skip to content

Fix live s1 read when main moves #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tcamise-gpsw merged 1 commit into from
Oct 15, 2026
Merged

Fix live s1 read when main moves #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion crates/stack-stat-core/tests/live_gh.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,10 @@ async fn discovers_a_three_pr_stack_and_loads_details() {
let details = github.pr_details(&stack).await.unwrap();
assert_eq!(details.prs.len(), 3);
assert!(details.prs.iter().all(|pr| pr.is_draft));
assert!(details.remote_rebase_branches.is_empty());
// s1-a is based on `main`, which moves, so it may legitimately be behind.
// s1-b and s1-c sit on fixture branches that only reset moves.
assert!(!details.remote_rebase_branches.contains("fixture/s1-b"));
assert!(!details.remote_rebase_branches.contains("fixture/s1-c"));
}

/// Assert a one-row single-mode view and return its row.
Expand Down
Loading