Repository navigation
Fix live s1 read when main moves - #48
Merged
Merged
Conversation
s1-a is based on main, so GitHub correctly reports it behind once main advances. The live read now asserts only that the layers above it, which sit on fixture branches, need no rebase. Found by the first dispatched live run, where both toolchains failed on the old assertion. Refs: #23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first dispatched
live-ghrun failed on both pinned and latest toolchains:discovers_a_three_pr_stack_and_loads_detailsasserted no remote rebase needed, but s1-a is based onmain, which advanced when #39 and #41 merged, so GitHub correctly reported it behind. The test now asserts only that s1-b and s1-c need no rebase. All other 15 live tests passed on both toolchains and the fixture check passed.Testing
cargo fmt --all -- --checkandcargo clippy -p stack-stat-core --all-targets --locked -- -D warnings: cleanlive-ghafter merge to confirm greenDocs and architecture
Refs: #23