Skip to content

fix: return ExactMatch mismatches for non-JSON primitives #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Andrew Barnes (Bortlesboat) wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −2
Open

fix: return ExactMatch mismatches for non-JSON primitives #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion py/autoevals/test_values.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from pytest import approx
from pytest import approx, mark

from autoevals.list import ListContains
from autoevals.number import NumericDiff
Expand Down Expand Up @@ -105,3 +105,11 @@ def test_exact_match():
expected,
expected_score,
)


@mark.parametrize("reference", [{"amount": 100}, [100]])
@mark.parametrize("non_json", [None, True, 100, 1.5])
def test_exact_match_json_and_non_json_values(reference, non_json):
evaluator = ExactMatch()
assert evaluator(output=non_json, expected=reference).score == 0
assert evaluator(output=reference, expected=non_json).score == 0
2 changes: 1 addition & 1 deletion py/autoevals/value.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ def normalize_value(value: Any, maybe_object: bool) -> str:
try:
if maybe_object:
return json.dumps(json.loads(value))
except json.JSONDecodeError:
except (json.JSONDecodeError, TypeError):
pass

return str(value)