fix: return ExactMatch mismatches for non-JSON primitives - #220
Open
Andrew Barnes (Bortlesboat) wants to merge 1 commit into
Open
fix: return ExactMatch mismatches for non-JSON primitives#220Andrew Barnes (Bortlesboat) wants to merge 1 commit into
Andrew Barnes (Bortlesboat) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExactMatch()(output=None, expected={"amount": 100})currently raisesTypeErrorinstead of returning a mismatch score. The same happens for booleans and numbers compared with a dict or list, including when the arguments are reversed. These comparisons now return0, using the existing normalization fallback.Validation
pytest py/autoevals/test_values.py py/autoevals/test_json.py -q: 16 passed after the fix.git diff --checkpassed for the changed files.The broader Python suite was attempted but is not green in this Windows environment: optional LiteLLM is missing, live API tests lack valid credentials, and the checkout's template symlink is not resolved.
Post-deploy validation
No service deployment is involved. After a package release, the example above should return a score of
0; I can help investigate any reported normalization regression.