Skip to content

Database: list-view chips painted over row titles on iconless rows #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
th3-br41n merged 1 commit into from
Jul 13, 2026
Merged

Database: list-view chips painted over row titles on iconless rows #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions apps/database/src/react/list-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,13 +269,17 @@ function ListItemFields({
}
return (
<div className="dbv-list__props">
{columns.map((column) => (
<DomSlot
key={column.propertyId}
build={() => paintPropertyValue(entity, column.propertyId, "inline")}
deps={[entity.id, column.propertyId, entity.properties[column.propertyId]]}
/>
))}
{columns.map((column) =>
// Title/name is the row heading — same skip as the editable strip
// above, else the full title paints AGAIN as the first chip.
column.propertyId === "title" || column.propertyId === "name" ? null : (
<DomSlot
key={column.propertyId}
build={() => paintPropertyValue(entity, column.propertyId, "inline")}
deps={[entity.id, column.propertyId, entity.properties[column.propertyId]]}
/>
),
)}
</div>
);
}
19 changes: 19 additions & 0 deletions apps/database/src/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1358,7 +1358,15 @@ body.is-resizing .db-inspector__resize {
border-color: color-mix(in srgb, var(--accent) 28%, transparent);
}

/* Each row child is pinned to its own grid column. Without the explicit
* `grid-column`s, an iconless entity's `:empty → display:none` glyph drops OUT
* of the grid flow and auto-placement shifts everything one track left: the
* title lands in the `auto` track (which can't shrink below the full nowrap
* string), the props strip lands in `1fr` (which collapses to ~0), and the
* right-packed chips overflow leftward ON TOP of the title — the "chips paint
* over the row title" bug on every iconless row. */
.dbv-list__glyph {
grid-column: 1;
width: 22px;
height: 22px;
border-radius: var(--radius-sm);
Expand All @@ -1374,13 +1382,15 @@ body.is-resizing .db-inspector__resize {
}

.dbv-list__title {
grid-column: 2;
font-weight: var(--text-weight-medium);
overflow: hidden;
text-overflow: ellipsis;
white-space: nowrap;
}

.dbv-list__props {
grid-column: 3;
display: flex;
align-items: center;
gap: var(--space-3);
Expand All @@ -1404,6 +1414,15 @@ body.is-resizing .db-inspector__resize {
max-width: min(28ch, 22vw);
}

/* The SDK date/link cells carry `width: 100%` for their panel/grid hosts; in
* this content-sized flex strip that inflates every one of them to the full
* 28ch cap (a 212px button for an 11-char date — and for an EMPTY value),
* which reads as misaligned phantom columns. Size them to their content here. */
.dbv-list__props .bs-cell-date-trigger,
.dbv-list__props .bs-cell-link-trigger {
width: auto;
}

.dbv-list__props .dbv-value {
color: var(--text-dim);
overflow: hidden;
Expand Down
Loading