Database: list-view chips painted over row titles on iconless rows#156
Merged
Conversation
Reproduced in the real shell (dogfood probe, computed grid):
`grid-template-columns` resolved to `133px 660px 0px` — an iconless entity's
glyph (`.dbv-list__glyph:empty { display:none }`) drops out of the grid FLOW,
so auto-placement shifts every child one track left: the title lands in the
`auto` track (which can't shrink below the full nowrap string), the props strip
lands in `1fr` (collapses to ~0), and the right-packed chips overflow leftward
ON TOP of the title. Every iconless row in every list view rendered this way.
Fixes, verified by re-running the probe (`0px 672px 122px`, chips right,
no overlap):
- pin each row child to its explicit grid column (glyph 1 / title 2 / props 3)
so a hidden glyph can't reflow the row;
- size the SDK date/link cells to content inside the strip — their panel/grid
`width:100%` inflated each to the full 28ch cap (a 212px button for an
11-char date, and for an EMPTY value), reading as phantom misaligned columns;
- read-only strip now skips `title`/`name` columns like the editable strip does
(it painted the full title AGAIN as the first chip).
Database react suite 49/49 green; per-app tsc clean.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug (user screenshot, v0.4.2)
In any Database list view (e.g. the curated Tasks → "Upcoming"), rows whose entities have no icon rendered the status/priority/date chips on top of the title text, at what looked like random fixed columns.
Root cause — reproduced with a real-shell probe
A dogfood Playwright probe dumped the row's computed grid:
grid-template-columns: 133.578px 660.422px 0px..dbv-list__glyph:empty { display: none }removes the glyph from the grid flow when the entity has no icon, so auto-placement shifts every child one track left:autotrack — which can't shrink below the fullnowrapstring,1fr— which collapses to ~0,justify-content: flex-end) chips overflow leftward over the title.Two amplifiers made it look like phantom table columns: the SDK date/link cells carry
width: 100%(for their panel/grid hosts), inflating each to the full28chcap inside the strip — a 212px button for an 11-char date, and for an empty value.Fixes
glyph 1 / title 2 / props 3) — a hidden glyph can no longer reflow the row.title/namecolumns like the editable strip already does (it painted the full title again as the first chip).Verification
Re-ran the probe against the rebuilt bundle:
grid-template-columns: 0px 671.906px 122.094px— title owns the middle track, chips content-sized at the right edge (pill 36px, date 86px), overlap geometrically impossible. Screenshot intests/dogfood/.sessions/900-dbv-list-probe/(harness) confirms visually. Database react suite 49/49, per-apptscclean.🤖 Generated with Claude Code