Extend the control-face ratchet to the shell renderer (Settings)#152
Merged
Conversation
…ettings) The control-face gate — native `<input>/<textarea>/<select>` must ride a shared face class (`.bs-input`/`.bs-select`) so a field lines up pixel-exact beside the button/select next to it — only scanned `apps/`. But the shell renderer uses the SAME faces (its `<TextField>` emits `.bs-input`), and Settings is exactly where "the input is a different height from the button beside it" keeps getting filed. So the design system's own privileged surface was the one place the ratchet couldn't see. Widen the scan to `packages/shell/src/renderer`, exempting its `ui/` folder (the shell's local primitive home — the sanctioned place a raw `<input>` is wrapped into a face, mirroring how the app scan exempts `packages/sdk`). Nine current Settings/Welcome/Help offenders are grandfathered into the baseline; the ratchet now fails any NEW hand-rolled shell control and shrinks as these nine migrate to `<TextField>`/`<SelectMenu>` when next touched. No feature files change — this is the enforcement mechanism, not the migrations. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The control-face gate enforces the design-system invariant that a native
<input>/<textarea>/<select>must ride a shared face class (.bs-input/.bs-select) — so a field is the same height as the button/select beside it. It only scannedapps/.But the shell renderer uses the same faces (
<TextField>emits.bs-input), and Settings is exactly where "the input is a different height from the control next to it" keeps getting filed. The design system's own privileged surface was the one place the ratchet couldn't see — so the enforcement half of the fix was missing there.What
check-control-faces.mjsto also scanpackages/shell/src/renderer, exempting itsui/folder — the shell's local primitive home, where a raw<input>is legitimately wrapped into a face (mirrors how the app scan exemptspackages/sdk).control-faces-baseline.json. The ratchet now:<TextField>/<SelectMenu>when next touched (stale-baseline detection forces the list down).Verified: gate green (10 baselined, 0 new); a synthetic new
<input>undersettings/trips it;css-tokens+app-reactivityratchets still green.No feature files change — this is the enforcement mechanism, not the migrations (several offenders live in files active branches are editing; they migrate under the ratchet later).
🤖 Generated with Claude Code