Settings → Sync: 'recent days' number field rides the shared TextField face#155
Merged
Conversation
…xtField face The selective-sync "keep the last N days" field was a hand-rolled `<input type=number>` with its own 5rem width, border, radius, and surface — so its box drifted from every other control in Settings. Now that `<TextField>` forwards `min`/`max`/`step` (the reason it couldn't use the primitive before), route it through `<TextField size=Sm>`; the `.sync-section__number` host keeps only the 5rem width + right-aligned digits, and the box comes from `.bs-input`. Drops it from the control-face baseline (10 → 9) — the ratchet now proves the full loop: primitive gap → primitive fix → consumer migrated → baseline shrinks. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The selective-sync "keep the last N days" field was a hand-rolled
<input type="number">with its own5remwidth + border + radius + surface — so its box drifted from every other control in Settings (the exact thing the control-face ratchet exists to stop).Now that
<TextField>forwardsmin/max/step(#154 — the reason this field couldn't use the primitive before), route it through<TextField size=Sm min={1} max={3650}>. The.sync-section__numberhost keeps only the5remwidth + right-aligned digits; the box (height / border / surface) comes from.bs-input.Why it's the clean one to migrate first
This closes the loop I built over the last three PRs end-to-end:
primitive gap found (#152 ratchet) → primitive fixed (#154 min/max) → consumer migrated → baseline shrinks (10 → 9).
The control-face ratchet's stale-baseline check requires the file be dropped from
control-faces-baseline.jsonin the same PR, so the two can't drift.Verified: control-faces green (9 baselined, sync no longer offends), css-tokens green,
typecheck:packagesclean, sync-section suite 7/7.🤖 Generated with Claude Code