Fix and validate rendered guidance examples - #295
Merged
Merged
Conversation
This was referenced Sep 9, 2026
nahiyankhan
marked this pull request as ready for review
September 11, 2026 05:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category: fix
User Impact: Readers see guidance examples that pass the parser used by ghost.
Problem: Two landing-page examples used material globs even though ghost requires explicit file paths.
Solution: Replace those globs with explicit paths and extract the example data so tests parse the same examples that the page renders.
Compatibility: No CLI, package schema, layout, or style changes.
Scope: One of five independent PRs split from the original #291. This branch targets
mainand contains only this concern, its tests, and its documentation.Related: Enforce resolved material access boundaries, Preserve guidance meaning in CLI output, Report incomplete guidance loading, Add read-only installed skill checks.
Validation:
pnpm run quality:all: passed on this standalone branch, including build, package/release checks, tests (229 passed), workspace builds, and package validations.git diff origin/main...HEAD --check: passed.Changeset: Not needed: private docs-site data and tests only.
ghost Review: Docs review packet assembled. Source inspection found no markup or style changes; the visual check is advisory. Rendered visual verification was not performed. Unbound test/data files and nodes without checks remain coverage gaps. Used the current
ghost review --package apps/docs/.ghost --base origin/main --format jsonand inspectedghost manifest; the olderghost check,--include-memory, anddump:cli-helpworkflows are unavailable in this checkout.File changes (3 files)
apps/docs/src/data/guidance-examples.tsapps/docs/src/pages/index.astropackages/ghost/test/docs-examples.test.tsScreenshots/Demos: Not captured: example paths and data placement changed, with no layout or style edits.