Skip to content

Preserve guidance meaning in CLI output - #292

Merged
nahiyankhan merged 1 commit into
mainfrom
fix/preserve-guidance-output
Sep 11, 2026
Merged

nahiyankhan merged 1 commit into
mainfrom
fix/preserve-guidance-output

Conversation

@nahiyankhan

@nahiyankhan nahiyankhan commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Category: fix
User Impact: Agents receive the selection rules and review guidance that authors wrote.

Problem: Gather truncated kind descriptions and omitted them from Markdown. Markdown review listed baseline references without the prose needed to assess a change.

Solution: Preserve full parsed kind descriptions, reuse the selection instructions in Markdown, and include referenced review prose with duplicate-section handling.

Compatibility: JSON kind purposes retain multiple paragraphs. Markdown includes more authored guidance; this PR does not add load diagnostics or change completeness types.

Scope: One of five independent PRs split from the original #291. This branch targets main and contains only this concern, its tests, and its documentation.

Related: Enforce resolved material access boundaries, Report incomplete guidance loading, Add read-only installed skill checks, Fix and validate rendered guidance examples.

Validation:

  • pnpm run quality:all: passed on this standalone branch, including build, package/release checks, tests (232 passed), workspace builds, and package validations.
  • Pre-commit checks and git diff origin/main...HEAD --check: passed.
  • Fresh dependency installation hit registry checksum errors. Validation used an isolated copy of the existing checkout's dependencies; the lockfile is unchanged.

Changeset: Existing patch changeset retained.

ghost Review: Review packet assembled against apps/docs/.ghost. This package does not bind the changed CLI/test/docs files, so the packet is coverage context, not a passing brand review. Used the current ghost review --package apps/docs/.ghost --base origin/main --format json and inspected ghost manifest; the older ghost check, --include-memory, and dump:cli-help workflows are unavailable in this checkout.

File changes (11 files)
File Purpose
.changeset/preserve-packet-meaning.md Record the guidance delivery fixes.
README.md Correct the command for task-free catalog inspection.
packages/ghost/README.md Correct the command for task-free catalog inspection.
packages/ghost/src/commands/gather-command.ts Render shared selection instructions and kind descriptions.
packages/ghost/src/embed/gather.ts Preserve full parsed kind descriptions.
packages/ghost/src/review/review-packet.ts Include baseline prose and avoid repeating previously shown guidance.
packages/ghost/src/skill-bundle/SKILL.md Explain kind selection rules and review baselines.
packages/ghost/src/skill-bundle/references/ground.md Tell the host to honor kind selection rules.
packages/ghost/src/skill-bundle/references/schema.md Document full kind purposes and baseline delivery.
packages/ghost/test/cli.test.ts Update assertions for the intended Markdown content.
packages/ghost/test/semantic-delivery.test.ts Cover complete purposes, baseline sections, deduplication, and missing-heading fallback.

Screenshots/Demos: N/A: no visual surface changes.

@nahiyankhan
nahiyankhan marked this pull request as ready for review September 11, 2026 05:07
@nahiyankhan
nahiyankhan merged commit ff9c093 into main Sep 11, 2026
6 checks passed
@nahiyankhan
nahiyankhan deleted the fix/preserve-guidance-output branch September 11, 2026 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant