build(deps-dev): bump vitest and coverage-v8 to 5.0.0 together - #189
Merged
Merged
Conversation
@vitest/coverage-v8 declares an exact peer on vitest, so the two cannot move independently. Dependabot opened them as separate pull requests (#183 bumped vitest, #182 bumped coverage-v8) and each one broke npm install on its own branch: npm error Could not resolve dependency: npm error peer vitest@"4.1.11" from @vitest/coverage-v8@4.1.11 npm error Conflicting peer dependency: vitest@4.1.11 Neither could ever go green alone, and no rebase would help — the fix has to be one commit that moves both. This is the same failure mode the dependabot.yml comment already documents for codeql-action's sub-actions. Verified on the upgrade: 20 test files, 287 tests passing, coverage reporting intact (99.39% statements, 100% lines/functions) and `vite build` clean. Supersedes #182 and #183. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://salmon-field-054249810-189.centralus.7.azurestaticapps.net |
This was referenced Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #183 (vitest) and #182 (@vitest/coverage-v8), both of which are permanently red.
Why they can't merge separately
@vitest/coverage-v8declares an exact peer dependency onvitest. Bumping either package alone makesnpm ciunsatisfiable:Both
Build & Deploy FrontendandBuild web image & scanfail on each branch for this reason. No rebase can fix it — the two versions have to move in the same commit.This is the same class of failure the
dependabot.ymlheader already documents forcodeql-action's sub-actions: a constraint that binds packages together regardless of whether the bump is major, minor or patch.Why Dependabot split them
The npm entry groups only
["minor", "patch"], so a major bypasses the group and arrives one PR per package. A follow-up onmainadds avitestgroup spanning all update types so this can't recur.Verification
Run locally against the upgrade:
npm testnpm run test:coveragenpm run buildnpm installpeer resolutionERESOLVE, 0 vulnerabilitiesNo source or test changes were needed — vitest 5 required no migration for this suite.
🤖 Generated with Claude Code