Skip to content

build(deps): group the vitest packages across all update types - #190

Merged
bgard68 merged 1 commit into
mainfrom
deps/vitest-group
Sep 13, 2026
Merged

bgard68 merged 1 commit into
mainfrom
deps/vitest-group

Conversation

@bgard68

@bgard68 bgard68 commented Sep 13, 2026

Copy link
Copy Markdown
Owner

Stops #182/#183 from recurring on the next vitest major. Pairs with #189, which is the one-commit fix for the instance that already happened.

The gap

The npm entry groups ["minor", "patch"] only:

groups:
  npm:
    patterns: ["*"]
    update-types: ["minor", "patch"]

So a major bypasses the group and arrives as one PR per package. @vitest/coverage-v8 pins vitest with an exact peer dependency, so splitting a vitest major across two PRs guarantees two permanently-red branches — each fails npm ci with ERESOLVE against the other's version, and no rebase can help.

The fix

A vitest group with no update-types filter, so it spans all bump sizes:

groups:
  vitest:
    patterns: ["vitest", "@vitest/*"]
  npm:
    patterns: ["*"]
    update-types: ["minor", "patch"]

Order matters: Dependabot assigns a dependency to the first group whose patterns match, so vitest must precede the catch-all.

This is the same reasoning the file already applies to github-actions, quoting its existing header comment: codeql-action's sub-actions must run the same version, and that constraint "holds regardless of whether a bump is major, minor or patch." The vitest pair has exactly that property.

Verification

  • yaml.safe_load parses the file; 9 update entries, unchanged from before.
  • Group order confirmed ['vitest', 'npm'], with vitest carrying no update-types filter.
  • Only additive — 11 insertions, no existing line modified. Non-ASCII characters in the surrounding comments verified intact (no mojibake).

🤖 Generated with Claude Code

The npm entry grouped ["minor", "patch"] only, so a major bypassed the
group and arrived one pull request per package. @vitest/coverage-v8
pins vitest with an exact peer, so that split produced two branches
that could never go green: #182 and #183, each failing `npm ci` with
ERESOLVE against the other's version.

github-actions is already grouped across all update types in this file
for precisely this reason - codeql-action's sub-actions must match, and
that holds regardless of bump size. The vitest pair has the same
property, so it gets the same treatment.

Listed before the catch-all group, because Dependabot assigns a
dependency to the first group whose patterns match it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@bgard68
bgard68 merged commit 3c0b888 into main Sep 13, 2026
10 checks passed
@bgard68
bgard68 deleted the deps/vitest-group branch September 13, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant