[Merged by Bors] - -Csplit-debuginfo=unpacked is default on nightly#1913
[Merged by Bors] - -Csplit-debuginfo=unpacked is default on nightly#1913gfreezy wants to merge 1 commit into
-Csplit-debuginfo=unpacked is default on nightly#1913Conversation
mockersf
added
A-Build-System
|
Ci reports |
|
#1096 will fix it. |
|
Yeah, the issue is fixed by #1906, so this would be safe to merge (because bors checks the version from after rebase), although if you do come back to the code then rebasing would also make CI pass here |
DJMcNab
left a comment
DJMcNab
left a comment
There was a problem hiding this comment.
We already use a -Z flag, so it being set as default only on nightly is fine.
DJMcNab
added
the
S-Ready-For-Final-Review
|
🔒 Permission denied Existing reviewers: click here to make gfreezy a reviewer |
DJMcNab
left a comment
DJMcNab
left a comment
There was a problem hiding this comment.
The rebased code is the same change as I previously approved.
In future, if you're going to experiment with the bors commands, I'd advise you not to delete the comments, and instead perhaps edit them to explain why you tried that. In this repository, no-one other than @cart has bors permissions at the moment, and so running the commands will fail.
|
@DJMcNab I don’t know how to get the pr merged. After glancing other merged prs, I thought running bors commands might be needed. |
|
Yup thats a reasonable guess. For now I'm the only one that can merge prs with |
|
bors r+ |
|
Pull request successfully merged into main. Build succeeded: |
bors
Bot
changed the title
-Csplit-debuginfo=unpacked is default on nightly-Csplit-debuginfo=unpacked is default on nightly
5 participants
rust-lang/cargo#9298