lastgenre: improve original fallback - #6890
Draft
JOJ0 wants to merge 1 commit into
Draft
Conversation
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
JOJ0
force-pushed
the
lastgenre_improve_original_fallback
branch
from
July 30, 2026 05:53
dfef785 to
a5f7d91
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## lastgenre_refactor_get_genre #6890 +/- ##
================================================================
- Coverage 75.61% 75.61% -0.01%
================================================================
Files 163 163
Lines 21324 21324
Branches 3362 3361 -1
================================================================
- Hits 16125 16124 -1
- Misses 4409 4410 +1
Partials 790 790
🚀 New features to boost your workflow:
|
JOJ0
force-pushed
the
lastgenre_improve_original_fallback
branch
from
July 30, 2026 06:04
a5f7d91 to
c53cebb
Compare
The discrepancy: - Normalization might help to keep more whitelisted genres! - But running through try_resolve_stage would be less code - The difference being that the latter reduces existing genres to the configured count which is not really fitting with a "last resort fallback to original genres" The here suggested solution: - We don't run through try_resolve_stage instantly because we want to make sure the "count" setting doesnt kick out anything but we apply aliases before whitelist check.
JOJ0
force-pushed
the
lastgenre_improve_original_fallback
branch
from
July 30, 2026 06:05
c53cebb to
1906d93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To Do