lastgenre: Refactor _get_genre

[JOJ0]

Description

The monolithic _get_genre method was broken down into several private instance methods and refactored for readability. The contract is kept and is already well tested (test_get_genre)

• Core Helpers - were moved from within _get_genre to reusable instance methods:

  • _try_resolve_stage: Handles the canonicalization and logging of genres for a specific stage.
  • _configured_fallback: Provides the configured fallback genre.

• Lookup Stages - some were complex enough to deserve their own instance method for readability, some stay inline in _get_genre:

  • _try_resolve_existing_genres: Manages the initial check for pre-existing genres and the cleanup_existing logic.
  • track stage: stays inline
  • album stage: indentical to track stage, but not worth moving / deduplication doesn't buy much (see subsequent PR though)
  • _fetch_artist_stage: Fetches and resolves artist-level genres, including multi-valued album artists and "Various Artists" logic.
  • _fetch_va_genres: specifically handles the plurality logic for "Various Artists" albums.

• Fallbacks:

  • _try_resolve_original_fallback: Handles the "keep_existing" logic that attempts to use/canonicalize originally present genres if no new ones are found.

Make sure to also look at subsequent PR's:

• lastgenre: improve original fallback #6890
• lastgenre: Album stage fall back to multi-valued albumartists #6893

To Do

• Documentation
• Changelog
• Tests (_get_genre was already well covered and the signature of the method was kept)

[github-actions]

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

[codecov]

Codecov Report

❌ Patch coverage is 55.84416% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.61%. Comparing base (e2889d1) to head (b4a7caf).
⚠️ Report is 38 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
beetsplug/lastgenre/__init__.py	55.84%	25 Missing and 9 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6474      +/-   ##
==========================================
- Coverage   75.62%   75.61%   -0.01%     
==========================================
  Files         163      163              
  Lines       21318    21324       +6     
  Branches     3361     3362       +1     
==========================================
+ Hits        16122    16125       +3     
- Misses       4405     4409       +4     
+ Partials      791      790       -1     

Files with missing lines	Coverage Δ
beetsplug/lastgenre/__init__.py	81.25% <55.84%> (-1.38%)	⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

[Copilot]

Pull request overview

grug see PR break big _get_genre into smaller helper methods, so code easier read and reason about, but keep same external behavior for lastgenre plugin.

Changes:

• move fallback + per-stage “resolve + log” logic into private instance helpers
• pull out “existing genres / cleanup_existing” handling and “original fallback” handling into dedicated helpers
• pull out artist-stage fetching (incl. VA plurality) into helper, so _get_genre main flow more straight

[github-actions]

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.