Skip to content

fix(CI): surface ESDK Java perf benchmark failures and tolerate shared config keys #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucasmcdonald3 merged 3 commits into from
Jun 23, 2026
Merged

fix(CI): surface ESDK Java perf benchmark failures and tolerate shared config keys #932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f150837
fix: surface ESDK Java perf benchmark failures and tolerate shared co…
lucasmcdonald3 Jun 22, 2026
5fa420e
TEMP (DO NOT MERGE): run perf benchmarks on PRs to validate dashboard
lucasmcdonald3 Jun 22, 2026
94fbf29
Revert "TEMP (DO NOT MERGE): run perf benchmarks on PRs to validate d…
lucasmcdonald3 Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...-performance-testing/benchmarks/java/src/main/java/com/amazon/esdk/benchmark/Program.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ public static void main(final String[] args) {
);
printSummary(results, options.outputPath());
} catch (final Exception ex) {
System.out.println("Benchmark failed: " + ex.getMessage());
System.err.println("Benchmark failed: " + ex.getMessage());
ex.printStackTrace();
System.exit(1);
}
}

Expand Down
3 changes: 3 additions & 0 deletions ...ormance-testing/benchmarks/java/src/main/java/com/amazon/esdk/benchmark/model/Config.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

package com.amazon.esdk.benchmark.model;

import com.fasterxml.jackson.annotation.JsonIgnoreProperties;
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.dataformat.yaml.YAMLFactory;
Expand All @@ -13,6 +14,8 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

// Other languages share this config file and add keys Java doesn't model.
@JsonIgnoreProperties(ignoreUnknown = true)
public final class Config {

private static final Logger logger = LoggerFactory.getLogger(Config.class);
Expand Down
Loading